If a user replies to an individual comment while another one deletes it, submitting the reply does not work but also shows no error (will be fixed in https://gitlab.com/gitlab-org/gitlab-ce/issues/58787). After page reload the reply is lost.
Inactive Accountchanged title from Replying to a comment afterit was deleted shows no error to Replying to a comment afterit was deleted shows no error
changed title from Replying to a comment afterit was deleted shows no error to Replying to a comment afterit was deleted shows no error
Similar behavior can already be seen when replying to a discussion and deleting it in another browser tab. I'm not sure if that should go into a separate issue.
@winh : So this is a consistency scenario you mean? And it also deals with someone deleting a comment. So this seems like a rare scenario? I'll put this as a P4 then.
@winh Could we do something like how Slack handles deleted messages? As in we would show an empty comment state, but the replies would still post successfully
Another option would be to just post the comment as a standalone comment if the root is deleted, like how we currently handle deleting the root comment of a thread. It's more confusing that way though, as it's not immediately clear what happened and where the thread went.
@victorwu Generally I agree but a user is still loosing their data and has indication that they should save it themselves prior to reloading / leaving the page. Maybe also consider the following use case:
user A writes some that is incorrect / incomplete
user B writes a comment with the correct information
user A chooses to delete their comment (after realizing that it is wrong)
I'm giving this a ~S2 because the workaround (check if the original comment has been deleted in a new browser tab, copy and paste the reply into a new comment) does not seem acceptable to me.
Thoughts on splitting this into two issues @winh? At minimum we need to show an error so that user doesn't think that their reply was saved and everything is good. After that we can start thinking through how to actually handle this use case.
Inactive Accountchanged title from Replying to a comment after it was deleted shows no error to Define behavior for starting discussion on a deleted comment
changed title from Replying to a comment after it was deleted shows no error to Define behavior for starting discussion on a deleted comment
GitLab is moving all development for both GitLab Community Edition
and Enterprise Edition into a single codebase. The current
gitlab-ce repository will become a read-only mirror, without any
proprietary code. All development is moved to the current
gitlab-ee repository, which we will rename to just gitlab in the
coming weeks. As part of this migration, issues will be moved to the
current gitlab-ee project.
If you have any questions about all of this, please ask them in our
dedicated FAQ issue.
Using "gitlab" and "gitlab-ce" would be confusing, so we decided to
rename gitlab-ce to gitlab-foss to make the purpose of this FOSS
repository more clear
I created a merge requests for CE, and this got closed. What do I
need to do?
Everything in the ee/ directory is proprietary. Everything else is
free and open source software. If your merge request does not change
anything in the ee/ directory, the process of contributing changes
is the same as when using the gitlab-ce repository.
Will you accept merge requests on the gitlab-ce/gitlab-foss project
after it has been renamed?
No. Merge requests submitted to this project will be closed automatically.
Will I still be able to view old issues and merge requests in
gitlab-ce/gitlab-foss?
Yes.
How will this affect users of GitLab CE using Omnibus?
No changes will be necessary, as the packages built remain the same.
How will this affect users of GitLab CE that build from source?
Once the project has been renamed, you will need to change your Git
remotes to use this new URL. GitLab will take care of redirecting Git
operations so there is no hard deadline, but we recommend doing this
as soon as the projects have been renamed.
Where can I see a timeline of the remaining steps?