Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 0
    • Merge Requests 0
  • Requirements
    • Requirements
    • List
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Issues
  • #58035

Closed
Open
Opened Feb 21, 2019 by James Ramsay@jramsay-gitlab⚡Developer

Incrementally expand merge request diffs in both direction

When a diff is collapsed between two hunks, expansion is currently only possible in one direction or the entire file. Also the ellipsis is hard to interpret. We should make the interface clearer and make it possible to expand in either direction.

Further details

It has been raised that the visual distinction between code folds and the source code is actually not strong enough. I expect that this doesn't conform to our accessibility guidelines.

Proposal

Show options to expand up 20, down 20, or all N lines between

Current Proposed
Screen_Shot_2019-02-21_at_3.04.56_PM Artboard
Screen_Shot_2019-02-21_at_3.05.29_PM Artboard2

Final Solution (Explanation here)

expand-full

Links / references

Edited Jul 16, 2019 by Jarek Ostrowski
Assignee
Assign to
12.2
Milestone
12.2 (Past due)
Assign milestone
Time tracking
None
Due date
None
Reference: gitlab-org/gitlab-foss#58035