Missing system notes icons after moving an issue

After moving issue gl-retrospectives/manage#7 (moved) to https://gitlab.com/gitlab-org/manage/issues/9, system notes icons are missing (compare gl-retrospectives/manage#7 (comment 121094095) with https://gitlab.com/gitlab-org/manage/issues/9#note_122331708).

before:

after:

Thanks @DouweM for reporting this.

@jamedjo also pointed out (thanks) that the markdown table on that issue also changed during the move with the the first row missing some columns and one of the link descriptions changing from [pdf] to the title of the file.

/cc @victorwu @smcgivern

added typebug label

changed milestone to %11.7

added backend label

@jprovaznik : is this a BE bug?

added [deprecated] Accepting merge requests label

changed milestone to %12.2

added priority3 label

@jprovaznik : is this a BE bug?

Yes, this is a backend issue, in JSON response I see that system_note_icon_name attribute is nil in discussions.json response sent from server.

changed milestone to %12.4

changed milestone to %12.5

mentioned in issue #55075 (closed)

Hi! I'm new to the project but I've got a few OS commits under my belt with other projects. I'd love to take a shot at this issue if it's still open? Cheers!

Thanks @richiethomas. Please go ahead with this issue and you can open a merge request when you are ready and you can ping me there and I can help get it to the right folks to review.

I’ll assign this issue to yourself now so people know.

assigned to @richiethomas

Awesome, thanks! I'll keep y'all posted on my progress. Glad to be contributing my first MR to GitLab.

Thanks for working on this @richiethomas! We've removed the ~"Accepting merge requests" label to avoid having multiple people working on the same issue.

removed [deprecated] Accepting merge requests label

@richiethomas great! I expect that the issue here is that when we move the issue, we don't copy the values from the system_notes_metadata table, which are used to provide the icons.

Cool, thanks for the guidance. Any timetable for this issue that I should be aware of? I'm thinking a few weeks here, since I'm unfamiliar with the codebase and it's a busy holiday season for me.

changed milestone to %12.3

added priority4 severity3 labels

Here's an update from my end- when I perform some actions on an issue and then move it to another project, I'm able to see the system notes icons from the previous project:

Still investigating and will update when I know more, but so far I'm unable to reproduce the issue on my local.

changed milestone to %Backlog

Hey y'all, FYI I haven't had much bandwidth to work on this issue lately. Not sure when I'll be able to pick it up in the near future, so I'm happy to un-assign myself if that's best. I look forward to contributing to GitLab at some point in the future.

Thanks for letting us know, @richiethomas!

removed priority4 label

changed weight to 2

unassigned @richiethomas

added [deprecated] Accepting merge requests label

I would like to give this one a shot. Is it still free to grab?

@Qwertie yes, that would be great thanks!

I was unable to reproduce this on my local version or on gitlab.com

All seems to be working as expected. The icons on the moved issue linked in the this issue's description are also displaying fine for me.

Something I noticed while testing this is that moving an issue shows the banner "Something went wrong" But it seems that nothing did go wrong because you are quickly redirected to the issue in its new location.

@Qwertie are you using Firefox? There was this issue which we just fixed: https://gitlab.com/gitlab-org/gitlab-ce/issues/61795

I am. Looks like that linked issue is the same thing I was seeing.

@Qwertie @jprovaznik should we close this issue, then? Or maybe it happens when an issue is moved across groups, not just between two projects in the same group?

Well it seems the linked issue where the problem was originally spotted is working now for me at least.

I also tested this with 2 groups and it seems to be fine as well

OK, cool! Super easy fix then

@jprovaznik could you close if this looks good to you?

Thanks @Qwertie, closing this one - it seems to work fine now

closed

added devopsplan label