Missing "Manage" button when Prometheus enabling alerts
Summary
On the Kubernetes Clusters page (Operations > Kubernetes) the Manage
button for the Prometheus installation disappears
after enabling metric alerts.
Steps to reproduce
- Enable Kubernetes
- Install Helm, Prometheus and Runner (Prometheus is
installed
) -
✅ Manage
button is shown at Operations > Kubernetes - Deploy application and make sure Metrics are shown
- Enable Metric alerts via Operations > Metrics (Prometheus is
updated
) -
🚫 Manage
button disappeared from Operations > Kubernetes - I can still manage Prometheus via Settings > Integration > Prometheus
What is the current bug behavior?
Manage
button for Prometheus is not shown after enabling metric alerts.
What is the expected correct behavior?
Manage
button for Prometheus should be shown even after enabling metric alerts.
Possible fixes
Tweak showManageButton()
in frontend to return true
also if the application is updated or updating.
diff --git a/app/assets/javascripts/clusters/components/application_row.vue b/app/assets/javascripts/clusters/components/application_row.vue
index 236bb1394c8..a619f24478b 100644
--- a/app/assets/javascripts/clusters/components/application_row.vue
+++ b/app/assets/javascripts/clusters/components/application_row.vue
@@ -134,7 +134,12 @@ export default {
return label;
},
showManageButton() {
- return this.manageLink && this.status === APPLICATION_STATUS.INSTALLED;
+ return (
+ this.manageLink &&
+ this.status === APPLICATION_STATUS.INSTALLED ||
+ this.status === APPLICATION_STATUS.UPDATED ||
+ this.status === APPLICATION_STATUS.UPDATING
+ );
},
manageButtonLabel() {
return s__('ClusterIntegration|Manage');
Edited by Peter Leitzen