Follow-up from "Resolve "Issue board card design""
The following discussions from !21229 (merged) should be addressed:
-
@filipa started a discussion: (+1 comment) we should not return HTML like this.
-
@filipa started a discussion: (+1 comment) Please do not return html in a computed property, this will allow for xss attacks, this needs to be done in the template
-
@filipa started a discussion: (+4 comments) please do not return html in a computed prop
-
@filipa started a discussion: this should be done in the template directly with class bindings
-
@filipa started a discussion: (+1 comment) this should be using timeago
-
@filipa started a discussion: (+1 comment) why are we calculating this on the frontend?
🤔 -
@filipa started a discussion: (+1 comment) why aren't we using the methods in
datetime_utility? -
@filipa started a discussion: No v-html please
-
@filipa started a discussion: (+2 comments) this should have a line break
-
@filipa started a discussion: (+1 comment) what is this?
-
@filipa started a discussion: (+4 comments) We should not return html like this
-
@filipa started a discussion: please avoid data-html
-
@filipa started a discussion: (+1 comment) what does
memomean? -
@filipa started a discussion: please no data-html, this allows for xss
-
@annabeldunstone started a discussion: (+2 comments) What is this for?
🤔 -
@annabeldunstone started a discussion: (+1 comment) What is this for? (same as https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21229/diffs#note_104227812)
If it's necessary I'm on board, but it's not a rule we use often (or at all, actually
😄 ); just wondering if we could accomplish any additional spacing with margins. I'm not seeing it in the design spec either but I might be missing something.