Side-by-side comment on unmodified code, box failures.
Summary
I believe this is probably due to the bug/null values here but visually is a different issue.
When attempting to start a discussion on lines that weren't changed in the merge request it will spam the write/comment box. And is consistently reproducible
Steps to reproduce
- Commit a file with x lines. (I've numbered mine for the screenshots)
- Commit changes to the file to a new branch (Modify groups of lines between other unchanged)
- Create Merge Request
- View Merge Request > Changes > Side-by-side
- Attempt to expand unmodified lines.
- Attempt to create a discussion on unmodified lines.
Example Project
Reproduced on customer 11.1.2, local 11.1.2, and gitlab.com
What is the current bug behavior?
What is the expected correct behavior?
Only the one write/field.
Possible fixes
The problem appears to be due to the null values returned when expanding these lines.
Internal ZD: https://gitlab.zendesk.com/agent/tickets/101009