Broken master in spec/features/boards/sidebar_spec.rb
As seen in https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/66073105.
1) Issue Boards subscription changes issue subscription
Failure/Error: expect(page).to have_css('.js-issuable-subscribe-button button.is-checked')
expected to find visible css ".js-issuable-subscribe-button button.is-checked" but there were no matches
# ./spec/features/boards/sidebar_spec.rb:358:in `block (4 levels) in <top (required)>'
# ./spec/features/boards/sidebar_spec.rb:354:in `block (3 levels) in <top (required)>'
# ./spec/features/boards/sidebar_spec.rb:21:in `block (3 levels) in <top (required)>'
# ./spec/features/boards/sidebar_spec.rb:21:in `block (2 levels) in <top (required)>'
2) Issue Boards subscription has checked subscription toggle when already subscribed
Failure/Error: expect(page).to have_css('.js-issuable-subscribe-button button:not(.is-checked)')
expected to find visible css ".js-issuable-subscribe-button button:not(.is-checked)" but there were no matches
# ./spec/features/boards/sidebar_spec.rb:374:in `block (4 levels) in <top (required)>'
# ./spec/features/boards/sidebar_spec.rb:370:in `block (3 levels) in <top (required)>'
# ./spec/features/boards/sidebar_spec.rb:21:in `block (3 levels) in <top (required)>'
# ./spec/features/boards/sidebar_spec.rb:21:in `block (2 levels) in <top (required)>'
Finished in 16 minutes 52 seconds (files took 23.05 seconds to load)
1586 examples, 2 failures, 68 pending
Failed examples:
rspec ./spec/features/boards/sidebar_spec.rb:350 # Issue Boards subscription changes issue subscription
rspec ./spec/features/boards/sidebar_spec.rb:362 # Issue Boards subscription has checked subscription toggle when already subscribed
This was introduced by https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18682. /cc @kushalpandya @iamphill
Edited by Rémy Coutable