Remove double-checked internal id generator
When we generate a new internal id for e.g. issues in 10.7, we double-check the incremented InternalId#last_value
with the maximum internal id present for a project's issues. This has been introduced in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18392 to help with transitioning to using AtomicInternalId
.
The reason for double-checking is that the tracked last_value
can get out of sync e.g. during a deploy when both old and new code is running at the same time (see https://gitlab.com/gitlab-org/gitlab-ce/issues/45269). With the next release (10.8), we can simply revert that change and remove the double-checking again.
Edited by Andreas Brandl