Right column of merge request discussion overflows
Summary
With right sidebar being visible, the merge request comments in parallel view on the right side overflow on some screen/window sizes (between 992px
and 1120px
).
Steps to reproduce
- open merge request with discussion
- open right sidebar
- change window size to the mentioned range
What is the current bug behavior?
Comments overflow:
What is the expected correct behavior?
Comments don't overflow.
The Solution (needs UX review)
Issue is caused by a white-space: nowrap;
rule from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/3012.
Setting white-space
to normal
fixes the issue in parallel mode, but it does cause the timestamp to wrap to a third line in inline mode:
Before Fix (white-space: nowrap
)
After Fix (white-space: normal
)
Should we proceed with setting the white-space to normal? Does UX/Design need to be consulted about this? Otherwise we could have separate rules for inline vs. parallel.
Edited by Dennis Tang