Move callback route(`google_api/auth/callback`) for Oauth under `-`
Summary
Move callback route(google_api/auth/callback
) for Oauth under -
.
Slack: https://gitlab.slack.com/archives/C72QLAA30/p1507393614000066
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Shinya Maeda marked this issue as related to #35954 (closed)
marked this issue as related to #35954 (closed)
- Maintainer
@dosuken123 I think that we should fix ship ASAP for that.
To conclude, the path would look like:
gitlab.com/-/google_api/auth/callback
Would it be better to maybe have?
gitlab.com/-/oauth2/google_api/callback
cc @bikebilly
1 - Kamil Trzciński added Next Patch Release label
added Next Patch Release label
- Author Maintainer
@ayufan I'll fix this before rc1.
Would it be better to maybe have?
The first path should be the purpose of authentication/authorization. Import/export feature is
import/**
. Login(omniauth) isuser/**
. We'll use Google provided features, so it'sgoogle_api/**
. - Author Maintainer
If Production team has already set up the path as callback, we should notify them
- Maintainer
It makes sense to me to use
google_api
.Can you also ensure that documentation is updated?
- Author Maintainer
@axil We will fix the callback route soon. The new path is
gitlab.com/-/google_api/auth/callback
.Reference: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14712
Edited by Shinya Maeda - Shinya Maeda added Architecture decision label
added Architecture decision label
- Achilleas Pipinellis mentioned in commit c756b087
mentioned in commit c756b087
- Developer
Thanks, fixed :)
- Shinya Maeda mentioned in merge request !14802 (merged)
mentioned in merge request !14802 (merged)
- Kamil Trzciński closed via merge request !14802 (merged)
closed via merge request !14802 (merged)
- Kamil Trzciński mentioned in commit 1faa97b2
mentioned in commit 1faa97b2
- Kamil Trzciński mentioned in commit 5f2901bf
mentioned in commit 5f2901bf