Company logo isn't properly sized after 9.4 update
Summary
We are running the omnibus installation of GitLab and just now upgraded to 9.4. I wanted to check out the new navigation and went ahead and enabled it for myself.
Our company logo (on the top left) was totally out of shape and takes up as much height as the image is at.
Steps to reproduce
- Use a custom logo (ours is sized 500x500)
- Upgrade to 9.4
- Turn on new navigation
What is the current bug behavior?
The header goes totally out of shape and the image isn't restricted to the header as shown below
What is the expected correct behavior?
The header to be properly sized and the logo to fit within the header
Relevant logs and/or screenshots
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 14.04 Current User: git Using RVM: no Ruby Version: 2.3.3p222 Gem Version: 2.6.6 Bundler Version:1.13.7 Rake Version: 10.5.0 Redis Version: 3.2.5 Git Version: 2.13.0 Sidekiq Version:5.0.0 Go Version: unknown
GitLab information Version: 9.4.0 Revision: 9bbe2ac Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: http://lserv-u14-1 HTTP Clone URL: http://lserv-u14-1/some-group/some-project.git SSH Clone URL: git@lserv-u14-1:some-group/some-project.git Using LDAP: no Using Omniauth: no
GitLab Shell Version: 5.3.1 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...
GitLab Shell version >= 5.3.1 ? ... OK (5.3.1) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 27/1 ... ok 28/2 ... ok 2/3 ... ok 2/4 ... ok 2/5 ... ok 2/6 ... ok 2/7 ... ok 28/8 ... ok 28/10 ... ok 27/11 ... ok 28/12 ... ok 28/13 ... ok 27/14 ... ok 2/15 ... ok 27/16 ... ok 27/17 ... ok 27/18 ... ok 27/19 ... ok 27/21 ... ok 27/22 ... ok 27/23 ... ok 27/24 ... ok 27/25 ... ok 2/26 ... ok 28/27 ... ok 2/28 ... ok 27/29 ... ok 27/30 ... ok 18/31 ... ok 27/32 ... ok 2/33 ... ok 2/34 ... ok 18/35 ... ok 2/36 ... ok 27/37 ... ok 27/38 ... ok 2/39 ... ok 20/40 ... ok 2/41 ... ok 2/43 ... ok 18/46 ... ok 28/47 ... ok 19/48 ... ok 28/49 ... ok 20/50 ... ok 20/51 ... ok 2/52 ... ok 2/53 ... ok 2/54 ... ok 31/55 ... ok 2/56 ... ok 28/57 ... ok 28/58 ... ok 18/59 ... ok 2/60 ... ok 28/63 ... ok 18/64 ... ok 2/65 ... ok 27/66 ... ok 27/67 ... ok 31/68 ... ok 28/69 ... ok 2/70 ... ok 21/71 ... ok 2/72 ... ok 21/73 ... ok 21/74 ... ok 33/78 ... ok 28/79 ... ok 28/80 ... ok 18/81 ... ok 31/82 ... ok 28/83 ... ok 28/85 ... ok 33/86 ... ok 2/87 ... ok 21/88 ... ok 20/89 ... ok 20/90 ... ok 20/91 ... ok 20/92 ... ok 20/93 ... ok 20/94 ... ok 20/95 ... ok 20/96 ... ok 20/97 ... ok 20/98 ... ok 2/99 ... ok 28/100 ... ok 28/101 ... ok 2/102 ... ok 35/105 ... ok 35/106 ... ok 20/109 ... ok 35/110 ... ok 35/111 ... ok 35/113 ... ok 35/114 ... ok 35/115 ... ok 35/116 ... ok 2/117 ... ok 20/118 ... ok 27/119 ... ok 2/121 ... ok 2/122 ... ok 20/123 ... ok 18/124 ... ok 39/125 ... ok 39/126 ... ok 39/127 ... ok 28/129 ... ok 27/130 ... ok 40/131 ... ok 20/132 ... ok 27/133 ... ok 27/134 ... ok 28/135 ... ok 28/136 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Access to /var/opt/gitlab/.ssh/authorized_keys: OK Send ping to redis server: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
Reply by email is disabled in config/gitlab.yml
Checking Reply by email ... Finished
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... no Try fixing it: sudo chown -R git /var/opt/gitlab/gitlab-rails/uploads sudo find /var/opt/gitlab/gitlab-rails/uploads -type f -exec chmod 0644 {} ; sudo find /var/opt/gitlab/gitlab-rails/uploads -type d -not -path /var/opt/gitlab/gitlab-rails/uploads -exec chmod 0700 {} ; For more information see: doc/install/installation.md in section "GitLab" Please fix the error above and rerun the checks. Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 27/1 ... yes 28/2 ... yes 2/3 ... yes 2/4 ... yes 2/5 ... yes 2/6 ... yes 2/7 ... yes 28/8 ... yes 28/10 ... yes 27/11 ... yes 28/12 ... yes 28/13 ... yes 27/14 ... yes 2/15 ... yes 27/16 ... yes 27/17 ... yes 27/18 ... yes 27/19 ... yes 27/21 ... yes 27/22 ... yes 27/23 ... yes 27/24 ... yes 27/25 ... yes 2/26 ... yes 28/27 ... yes 2/28 ... yes 27/29 ... yes 27/30 ... yes 18/31 ... yes 27/32 ... yes 2/33 ... yes 2/34 ... yes 18/35 ... yes 2/36 ... yes 27/37 ... yes 27/38 ... yes 2/39 ... yes 20/40 ... yes 2/41 ... yes 2/43 ... yes 18/46 ... yes 28/47 ... yes 19/48 ... yes 28/49 ... yes 20/50 ... yes 20/51 ... yes 2/52 ... yes 2/53 ... yes 2/54 ... yes 31/55 ... yes 2/56 ... yes 28/57 ... yes 28/58 ... yes 18/59 ... yes 2/60 ... yes 28/63 ... yes 18/64 ... yes 2/65 ... yes 27/66 ... yes 27/67 ... yes 31/68 ... yes 28/69 ... yes 2/70 ... yes 21/71 ... yes 2/72 ... yes 21/73 ... yes 21/74 ... yes 33/78 ... yes 28/79 ... yes 28/80 ... yes 18/81 ... yes 31/82 ... yes 28/83 ... yes 28/85 ... yes 33/86 ... yes 2/87 ... yes 21/88 ... yes 20/89 ... yes 20/90 ... yes 20/91 ... yes 20/92 ... yes 20/93 ... yes 20/94 ... yes 20/95 ... yes 20/96 ... yes 20/97 ... yes 20/98 ... yes 2/99 ... yes 28/100 ... yes 28/101 ... yes 2/102 ... yes 35/105 ... yes 35/106 ... yes 20/109 ... yes 35/110 ... yes 35/111 ... yes 35/113 ... yes 35/114 ... yes 35/115 ... yes 35/116 ... yes 2/117 ... yes 20/118 ... yes 27/119 ... yes 2/121 ... yes 2/122 ... yes 20/123 ... yes 18/124 ... yes 39/125 ... yes 39/126 ... yes 39/127 ... yes 28/129 ... yes 27/130 ... yes 40/131 ... yes 20/132 ... yes 27/133 ... yes 27/134 ... yes 28/135 ... yes 28/136 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.3 ? ... yes (2.3.3) Git version >= 2.7.3 ? ... yes (2.13.0) Active users: ... 16
Checking GitLab ... Finished
Possible fixes
It looks like the h1.title img
is missing a height
parameter that existed in the old navigation.