Roadmap - remove vue template compiler: Change vue components `.js` files into `.vue` files
In order to aim for a more consistent code base and to eventually remove the template compiler from our production bundles we need to move our vue components in .js
files into .vue
files.
List of vue components in .js
files:
-
MR Widget components
-
mr_widget_archived.js
@filipa -
mr_widget_auto_merge_failed.js
@filipa -
mr_widget_checking.js
@filipa -
mr_widget_closed.js
@filipa -
mr_widget_conflicts.js
@filipa -
mr_widget_failed_to_merge.js
@filipa -
mr_widget_merge_when_pipeline_succeeds.js
@filipa -
mr_widget_merged.js
@filipa -
mr_widget_merging.js
@filipa -
mr_widget_missing_branch.js
-
mr_widget_not_allowed.js
-
mr_widget_nothing_to_merge.js
@gtsiolis -
mr_widget_memory_graph.js
@gtsiolis -
mr_widget_pipeline_blocked.js
-
mr_widget_pipeline_failed.js
-
mr_widget_ready_to_merge.js
@gtsiolis -
mr_widget_sha_mismatch.js
@gtsiolis -
mr_widget_squash_before_merge.js
-
mr_widget_unresolved_discussions.js
@gtsiolis -
mr_widget_wip.js
@gtsiolis -
mr_widget_author.js
@filipa -
mr_widget_author_time.js
@filipa -
mr_widget_deployment.js
-
mr_widget_header.js
@filipa -
mr_widget_memory_usage.js
@gtsiolis -
mr_widget_merge_help.js
@filipa -
mr_widget_pipeline.js
@filipa -
mr_widget_related_links.js
@filipa -
mr_widget_status_icon.js
@filipa
-
- Issue boards components
-
Cycle Analytics components
-
cycle_analytics/show.html.haml
-
- Diff notes components
-
Filtered Search components
-
recent_searches_dropdown_content
@gtsiolis
-
- Merge Conflicts
- Pipelines schedules
-
Multiple Assignees
-
assignees.js
@gtsiolis
-
- Time tracking
Designs
- Show closed items
Relates to
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Filipa Lacerda mentioned in issue #27486 (moved)
mentioned in issue #27486 (moved)
- Filipa Lacerda mentioned in issue #34476 (closed)
mentioned in issue #34476 (closed)
- Developer
This gives a huge performance boost, much more than I originally thought. For large merge requests we can spend up to 6 seconds just compiling a simple button into its equivalent JS output. For smaller pages, it won't be that noticeable but would still give us an improvement in performance.
- Filipa Lacerda mentioned in merge request !13539 (merged)
mentioned in merge request !13539 (merged)
- Filipa Lacerda marked the checklist item Pipelines schedules as completed
marked the checklist item Pipelines schedules as completed
- Filipa Lacerda mentioned in issue #38158 (closed)
mentioned in issue #38158 (closed)
- Filipa Lacerda mentioned in issue #38017 (moved)
mentioned in issue #38017 (moved)
- Filipa Lacerda assigned to @filipa
assigned to @filipa
- Inactive Account mentioned in issue #35932 (moved)
mentioned in issue #35932 (moved)
- Inactive Account mentioned in issue #38189 (closed)
mentioned in issue #38189 (closed)
- Filipa Lacerda mentioned in merge request !14435 (closed)
mentioned in merge request !14435 (closed)
- Filipa Lacerda mentioned in merge request !14463 (merged)
mentioned in merge request !14463 (merged)
- Filipa Lacerda mentioned in merge request !14464 (merged)
mentioned in merge request !14464 (merged)
- Victor Wu added Plan [DEPRECATED] label
added Plan [DEPRECATED] label
- Filipa Lacerda mentioned in merge request !14579 (merged)
mentioned in merge request !14579 (merged)
- Contributor
We can break these up into separate issues and do maybe 2 a month? cc @victorwu So we won't finish all these in a month.
- Contributor
@victorwu can you break up the rest into individual issues?
- Filipa Lacerda changed the description
changed the description
- Filipa Lacerda changed the description
changed the description
- Author Contributor
@victorwu we don't have man power :( we are moving this out of 10.2
1 - Filipa Lacerda mentioned in merge request !14690 (merged)
mentioned in merge request !14690 (merged)
- Filipa Lacerda changed the description
changed the description
- Filipa Lacerda changed title from Change vue components
.js
files into.vue
files to Roadmap - remove vue template compiler: Change vue components.js
files into.vue
fileschanged title from Change vue components
.js
files into.vue
files to Roadmap - remove vue template compiler: Change vue components.js
files into.vue
files - Author Contributor
- Filipa Lacerda removed Plan [DEPRECATED] label
removed Plan [DEPRECATED] label
- Filipa Lacerda mentioned in issue #39999 (moved)
mentioned in issue #39999 (moved)
- Author Contributor
Not actively working on this
- Filipa Lacerda removed assignee
removed assignee
- Filipa Lacerda mentioned in issue #41582 (closed)
mentioned in issue #41582 (closed)
- Filipa Lacerda mentioned in merge request !16561 (merged)
mentioned in merge request !16561 (merged)
- Filipa Lacerda mentioned in merge request !16564 (merged)
mentioned in merge request !16564 (merged)
- Filipa Lacerda marked this issue as related to #41582 (closed)
marked this issue as related to #41582 (closed)
- Filipa Lacerda mentioned in merge request !16825 (merged)
mentioned in merge request !16825 (merged)
- Filipa Lacerda changed the description
changed the description
- Filipa Lacerda mentioned in merge request !16857 (merged)
mentioned in merge request !16857 (merged)
- Filipa Lacerda mentioned in merge request !16863 (merged)
mentioned in merge request !16863 (merged)
- Filipa Lacerda changed the description
changed the description
- George Tsiolis mentioned in merge request !16888 (merged)
mentioned in merge request !16888 (merged)
- George Tsiolis mentioned in merge request !16947 (merged)
mentioned in merge request !16947 (merged)
- George Tsiolis mentioned in merge request !16948 (merged)
mentioned in merge request !16948 (merged)
- George Tsiolis mentioned in merge request !16951 (merged)
mentioned in merge request !16951 (merged)
- George Tsiolis mentioned in merge request !16952 (merged)
mentioned in merge request !16952 (merged)
- George Tsiolis mentioned in merge request !17397 (merged)
mentioned in merge request !17397 (merged)
- George Tsiolis mentioned in merge request !17398 (merged)
mentioned in merge request !17398 (merged)
- George Tsiolis mentioned in merge request !17399 (merged)
mentioned in merge request !17399 (merged)
- George Tsiolis mentioned in merge request !17533 (merged)
mentioned in merge request !17533 (merged)
- George Tsiolis mentioned in merge request !17536 (merged)
mentioned in merge request !17536 (merged)
- George Tsiolis mentioned in merge request !17538 (merged)
mentioned in merge request !17538 (merged)
- George Tsiolis mentioned in merge request !17544 (merged)
mentioned in merge request !17544 (merged)
- George Tsiolis mentioned in merge request !17545 (merged)
mentioned in merge request !17545 (merged)
- George Tsiolis mentioned in merge request !17546 (merged)
mentioned in merge request !17546 (merged)
- George Tsiolis mentioned in merge request !17666 (merged)
mentioned in merge request !17666 (merged)
- Filipa Lacerda mentioned in merge request !17727 (closed)
mentioned in merge request !17727 (closed)
- Author Contributor
@gtsiolis can you please tell which ones are you working on? Thanks!
1 - Developer
@filipa the following have been merged (you can mark them as complete although some minor refactoring could take place in the future once all of these are complete like folder renaming as discussed in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17533#note_62041970):
- MR Widget components:
memory_usage.js
,memory_graph.js
,nothing_to_merge.js
- Issue boards components:
board.js
,board_list.js
,board_new_issue.js
- Filtered Search components:
recent_searches_dropdown_content.js
- Multiple Assignees:
assignees.js
,assignee_title.js
,sidebar_assignees.js
- Time tracking:
time_tracker.js
The following are the ones I'm currently working on:
- MR Widget components:
sha_mismatch.js
,ready_to_merge.js
,unresolved_discussions.js
,wip.js
- Issue boards components:
board_blank_state.js
- Time tracking:
time_tracker.js
,spent_only_pane.js
,sidebar_time_tracking.js
,no_tracking_pane.js
,help_state.js
,estimate_only_pane.js
,comparison_pane.js
,collapsed_pane.js
Note that some
.js
files have been renamed removing any prefix or suffix likemr_widget_wip.js
towip.vue
.Edited by George Tsiolis - MR Widget components:
- Filipa Lacerda marked the checklist item
mr_widget_deployment.js
as completedmarked the checklist item
mr_widget_deployment.js
as completed - Filipa Lacerda marked the checklist item
mr_widget_missing_branch.js
as completedmarked the checklist item
mr_widget_missing_branch.js
as completed - Filipa Lacerda marked the checklist item
mr_widget_not_allowed.js
as completedmarked the checklist item
mr_widget_not_allowed.js
as completed - Filipa Lacerda marked the checklist item
mr_widget_pipeline_blocked.js
as completedmarked the checklist item
mr_widget_pipeline_blocked.js
as completed - Filipa Lacerda marked the checklist item
mr_widget_pipeline_failed.js
as completedmarked the checklist item
mr_widget_pipeline_failed.js
as completed - Filipa Lacerda marked the checklist item
mr_widget_pipeline_failed.js
as incompletemarked the checklist item
mr_widget_pipeline_failed.js
as incomplete - Filipa Lacerda changed the description
changed the description
- Author Contributor
Thank you @gtsiolis updated them all
- Developer
Thanks @filipa !
- George Tsiolis mentioned in merge request !17931 (merged)
mentioned in merge request !17931 (merged)
- George Tsiolis mentioned in merge request !18277 (merged)
mentioned in merge request !18277 (merged)
- George Tsiolis mentioned in merge request !18318 (merged)
mentioned in merge request !18318 (merged)
- George Tsiolis mentioned in merge request !18319 (merged)
mentioned in merge request !18319 (merged)
- Filipa Lacerda marked the checklist item
mr_widget_pipeline_failed.js
as completedmarked the checklist item
mr_widget_pipeline_failed.js
as completed - George Tsiolis mentioned in merge request !18676 (merged)
mentioned in merge request !18676 (merged)
- George Tsiolis mentioned in merge request !18677 (merged)
mentioned in merge request !18677 (merged)
- George Tsiolis mentioned in merge request !18710 (merged)
mentioned in merge request !18710 (merged)
- Inactive Account mentioned in merge request !18733 (merged)
mentioned in merge request !18733 (merged)
- George Tsiolis mentioned in merge request !18813 (merged)
mentioned in merge request !18813 (merged)
- George Tsiolis mentioned in merge request !20068 (merged)
mentioned in merge request !20068 (merged)
- Developer
@filipa you can check all items within:
- MR Widget components
-
Time tracking (This is minor, but could you rename
collapsed_pane
tocollapsed_state
, since I provided you with a wrong name?) :)
Also, I saw your work in !20067 (merged) and did some similar work in !20068 (merged). I've been watching for this a merge request like this since https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16888#note_57348346. Thanks for the inspiration @filipa!
1 - Filipa Lacerda marked the checklist item
mr_widget_ready_to_merge.js
@gtsiolis as completedmarked the checklist item
mr_widget_ready_to_merge.js
@gtsiolis as completed - Filipa Lacerda marked the checklist item
mr_widget_sha_mismatch.js
@gtsiolis as completedmarked the checklist item
mr_widget_sha_mismatch.js
@gtsiolis as completed - Filipa Lacerda marked the checklist item
mr_widget_squash_before_merge.js
as completedmarked the checklist item
mr_widget_squash_before_merge.js
as completed - Filipa Lacerda marked the checklist item
mr_widget_unresolved_discussions.js
@gtsiolis as completedmarked the checklist item
mr_widget_unresolved_discussions.js
@gtsiolis as completed - Filipa Lacerda marked the checklist item
mr_widget_wip.js
@gtsiolis as completedmarked the checklist item
mr_widget_wip.js
@gtsiolis as completed - Mike Greiling marked the checklist item MR Widget components as completed
marked the checklist item MR Widget components as completed
- Mike Greiling marked the checklist item Filtered Search components as completed
marked the checklist item Filtered Search components as completed
- Mike Greiling marked the checklist item Multiple Assignees as completed
marked the checklist item Multiple Assignees as completed
- Filipa Lacerda marked the checklist item
spent_only_pane
@gtsiolis as completedmarked the checklist item
spent_only_pane
@gtsiolis as completed - Filipa Lacerda marked the checklist item
sidebar_time_tracking
@gtsiolis as completedmarked the checklist item
sidebar_time_tracking
@gtsiolis as completed - Filipa Lacerda marked the checklist item
no_tracking_pane
@gtsiolis as completedmarked the checklist item
no_tracking_pane
@gtsiolis as completed - Filipa Lacerda marked the checklist item
help_state
@gtsiolis as completedmarked the checklist item
help_state
@gtsiolis as completed - Filipa Lacerda marked the checklist item
estimate_only_pane
@gtsiolis as completedmarked the checklist item
estimate_only_pane
@gtsiolis as completed - Filipa Lacerda marked the checklist item
comparison_pane
@gtsiolis as completedmarked the checklist item
comparison_pane
@gtsiolis as completed - Filipa Lacerda marked the checklist item
empty_state.js
as completedmarked the checklist item
empty_state.js
as completed - Filipa Lacerda marked the checklist item
tabs.js
as completedmarked the checklist item
tabs.js
as completed - Filipa Lacerda marked the checklist item
footer.js
as completedmarked the checklist item
footer.js
as completed - Filipa Lacerda marked the checklist item
lists_dropdown.js
as completedmarked the checklist item
lists_dropdown.js
as completed - Filipa Lacerda marked the checklist item
remove_issue.js
as completedmarked the checklist item
remove_issue.js
as completed - Filipa Lacerda marked the checklist item
board_blank_state.js
@gtsiolis as completedmarked the checklist item
board_blank_state.js
@gtsiolis as completed - Filipa Lacerda mentioned in merge request !20106 (merged)
mentioned in merge request !20106 (merged)
- George Tsiolis mentioned in merge request !21851 (merged)
mentioned in merge request !21851 (merged)
- Mike Greiling marked the checklist item
board_card.js
as completedmarked the checklist item
board_card.js
as completed - Mike Greiling mentioned in merge request !22210 (merged)
mentioned in merge request !22210 (merged)
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- Filipa Lacerda marked the checklist item Time tracking as completed
marked the checklist item Time tracking as completed
- Mike Greiling mentioned in merge request !29955 (merged)
mentioned in merge request !29955 (merged)
- Maintainer
Hey!
GitLab is moving all development for both GitLab Community Edition and Enterprise Edition into a single codebase. The current
gitlab-ce
repository will become a read-only mirror, without any proprietary code. All development is moved to the currentgitlab-ee
repository, which we will rename to justgitlab
in the coming weeks. As part of this migration, issues will be moved to the currentgitlab-ee
project.If you have any questions about all of this, please ask them in our dedicated FAQ issue.
https://gitlab.com/gitlab-org/gitlab-ee/issues/13855
You can also find more information here:
https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
- https://about.gitlab.com/2019/08/23/a-single-codebase-for-gitlab-community-and-enterprise-edition/
Frequently Asked Questions
For an up to date list of questions and answers, please take a look at
https://gitlab.com/gitlab-org/gitlab-ee/issues/13855
What will we do with the repository names?
https://gitlab.com/gitlab-org/gitlab-ee/ will become https://gitlab.com/gitlab-org/gitlab, and https://gitlab.com/gitlab-org/gitlab-ce will become https://gitlab.com/gitlab-org/gitlab-foss.
Why rename gitlab-ce to gitlab-foss?
Using "gitlab" and "gitlab-ce" would be confusing, so we decided to rename gitlab-ce to gitlab-foss to make the purpose of this FOSS repository more clear
I created a merge requests for CE, and this got closed. What do I need to do?
You will need to create a merge request at https://gitlab.com/gitlab-org/gitlab-ee/. This link will eventually redirect to https://gitlab.com/gitlab-org/gitlab.
How does the licensing work in this new setup?
Everything in the
ee/
directory is proprietary. Everything else is free and open source software. If your merge request does not change anything in theee/
directory, the process of contributing changes is the same as when using the gitlab-ce repository.Will you accept merge requests on the gitlab-ce/gitlab-foss project after it has been renamed?
No. Merge requests submitted to this project will be closed automatically.
Will I still be able to view old issues and merge requests in gitlab-ce/gitlab-foss?
Yes.
How will this affect users of GitLab CE using Omnibus?
No changes will be necessary, as the packages built remain the same.
How will this affect users of GitLab CE that build from source?
Once the project has been renamed, you will need to change your Git remotes to use this new URL. GitLab will take care of redirecting Git operations so there is no hard deadline, but we recommend doing this as soon as the projects have been renamed.
Where can I see a timeline of the remaining steps?
https://gitlab.com/gitlab-org/gitlab-ee/issues/13304
Will community contributions submitted to the new "gitlab" repository be available in the new gitlab-foss repository?
Yes, these changes will be synced to gitlab-foss automatically, several times per day.
- 🤖 GitLab Bot 🤖 locked this issue
locked this issue