Faulty diff avatar behavior when commenting on diff discussion on MR Discussion tab
Related to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7357
Steps to reproduce:
-
Go to a merge request
-
Open the Changes tab
-
Comment on a line
-
Go to the Discussion tab
-
Notice the new discussion that looks like this:
-
Add a comment through that discussion
-
Notice the avatar by the side of the discussion
-
Click the avatar
-
Notice that the discussion is now totally gone with no way to restore it
I think it's fine to simply NOT show avatars for these discussions on the Discussions tab, only on the Changes tab. There's no reason to expand/collapse a discussion on the Discussion tab inside the diff since there's already the "Toggle discussion" link.
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/29237
/cc @iamphill