JS error when commenting on commit diff discussion on MR Discussion tab
Related to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7357
Steps to reproduce:
-
Go to a merge request
-
Open one of the merge requests commits in a new tab
-
Comment on a line in the commit
-
Go back to the MR tab
-
Notice the new discussion that looks like this:
-
Add a comment through that discussion
-
See this JS error in your console:
TypeError: Cannot read property 'id' of undefined
at VueComponent.setDiscussionVisible (diff_note_avatars.js:149)
at VueComponent.boundFn [as setDiscussionVisible] (vue.common.js:127)
at VueComponent.<anonymous> (diff_note_avatars.js:55)
at Array.<anonymous> (vue.common.js:460)
at nextTickHandler (vue.common.js:409)
The offending line is this one: https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/javascripts/diff_notes/components/diff_note_avatars.js#L149
The reason is that commit diff discussions don't have a discussion
object like MR diff discussions do, since they're not resolvable etc. I think it's fine to simply NOT show avatars for these discussions on the Discussions tab.
/cc @iamphill