Comments on job logs

Issue idea came from: https://gitlab.com/gitlab-org/gitlab-ce/issues/24845#note_23524320

to quote @godfat

In my mind, each pipeline should act like a merge request. Well, not really because we don't need to assign pipeline, or do we? I imagine that the pusher would be the pipeline author, and people could comment and subscribe to a pipeline, making them participants. This would be useful especially commenting on the job console log.

Usecase

  • Easily point out job failures and be able to discuss them.

Problem

Currently its not possible to comment inline in the job log to discuss failures in more detail.

Proposal

  • Be able to comment inside of a job log, like we currently do in a code diff.

Quick mockup:

comment-on-log-no-comment comment-on-log-comment

Follow up:

Have these comments show up as conversations inside the Pipeline, commit and Merge Request view, similar as we do now so if you comment on a committed file and it shows up as a discussion on the MR discussion.

Value

  • Easy discussion on job failures.
  • Consistent discussions across object views.

cc: @markpundsack @joshlambert @godfat @filipa @grzesiek @victorwu @smcgivern