Use warning icon for stages/jobs that are allowed to fail

Description

When a job fails that is allowed to fail, we use a warning symbol for the status of the pipeline as a whole; why not use the same symbol for the stage and individual jobs as well?

Proposal

Use the warning icon (app/views/shared/icons/_icon_status_warning.svg) in the pipeline list, pipeline detail page graph, pipeline detail page build list, and build detail pages. And anywhere else we show the status of an individual job or stage that failed, but was allowed to fail.

Single Source of Truth

This should just need the warning icon, with a tooltip:

Mini pipeline graph in pipeline list:

build view builds list:

build list in MR/Commit view:

This tag should be gone:

status should be:

color used should be: #E75E40

Links / references

• https://gitlab.com/gitlab-org/gitlab-ce/issues/21925#note_15050947

Places where it needs to be changed

• Pipelines list, in the mini pipeline graph in the column 'stages'- https://gitlab.com/gitlab-org/gitlab-ce/pipelines

• Pipelines list, in the status button in the column 'status'- https://gitlab.com/gitlab-org/gitlab-ce/pipelines

• Builds List, in the status button in the column 'status' - https://gitlab.com/gitlab-org/gitlab-ce/builds

• Build view, in top message status button - https://gitlab.com/gitlab-org/gitlab-ce/builds/4867934

• Build view, in right sidebar builds list - https://gitlab.com/gitlab-org/gitlab-ce/builds/4867934

• Pipeline view, in the pipeline Graph - https://gitlab.com/gitlab-org/gitlab-ce/pipelines/4521196

• Pipeline view, in the status button in the build list below the pipeline Graph - https://gitlab.com/gitlab-org/gitlab-ce/pipelines/4521196

• Merge request view, in the builds tab in the pipeline graph - !6691 (merged) (builds)

• Merge request view, in the builds tab in the build list below the pipeline Graph - !6691 (merged) (builds)

• Merge request view, in the builds commit tab - !6691 (merged) (commits)

• Project page in last commit message - https://gitlab.com/gitlab-org/gitlab-ce

• Project forks page if a project has a build status - https://gitlab.com/gitlab-org/gitlab-ce/forks

• Projects page status icon if a project has a build status - https://gitlab.com/dashboard/projects

• Profile view, in the projects tab - https://gitlab.com/u/filipa/projects

• Profile view, in the contributed tab - https://gitlab.com/u/filipa/contributed