Make `spec/mailers/notify_spec.rb` more robust
It appears that depending on the user's name, some spec would fail:
2nd Try error in ./spec/mailers/notify_spec.rb:98:
expected the body to match /Ms. Ara O'Reilly/, but did not. Actual body was: "<html lang=\"en\">\n<head>\n<meta content=\"text/html; charset=utf-8\" http-equiv=\"Content-Type\">\n<title>\nGitLab\n</title>\n<link rel=\"stylesheet\" media=\"screen\" href=\"http://localhost/assets/notify.css\" />\n\n</head>\n<body>\n<div class=\"content\">\n<p>\nAssignee changed\nfrom\n<strong>Previous Assignee</strong>\nto\n<strong>Ms. Ara O'Reilly</strong>\n</p>\n\n\n</div>\n<div class=\"footer\" style=\"margin-top: 10px;\">\n<p>\n—\n<br>\nReply to this email directly or\n<a href=\"http://localhost/namespace24/gitlabhq/issues/1\">view it on GitLab</a>.\n<br>\nYou're receiving this email because of your account on localhost.\nIf you'd like to receive fewer emails, you can\n<a href=\"http://localhost/sent_notifications/REDACTED/unsubscribe\">unsubscribe</a>\nfrom this thread or\nadjust your notification settings.\n<script type=\"application/ld+json\">{\"@context\":\"http://schema.org\",\"@type\":\"EmailMessage\",\"action\":{\"@type\":\"ViewAction\",\"name\":\"View Issue\",\"url\":\"http://localhost/namespace24/gitlabhq/issues/1\"}}</script>\n</p>\n</div>\n</body>\n</html>\n" See the log for yourself: https://dev.gitlab.org/gitlab/gitlab-ee/builds/121623
Edited by Rémy Coutable