Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Issues
  • #15591
Closed
Open
Created Apr 25, 2016 by Rémy Coutable@rymaiMaintainer

Private project's namespace and name leak in new MR view

As described in https://gitlab.com/gitlab-org/gitlab-ce/issues/15532#guessing-namespaces, on the new MR (compare) view, you can see a private project's namespace and name by simply putting merge_request%5Btarget_project_id%5D=3 in the URL.

For instance, in my local setup, the twitter/flight project is private to my current user1 but I can see its namespace and name in the view:

Screen_Shot_2016-04-25_at_15.10.54

As a fix, I suggest adding the following change in MergeRequests::BuildService#execute:

      def execute
        merge_request = MergeRequest.new(params)

        # Set MR attributes
        merge_request.can_be_created = false
        merge_request.compare_commits = []
        merge_request.source_project = project unless merge_request.source_project
+       merge_request.target_project = nil unless can?(current_user, :read_project, merge_request.target_project)
        merge_request.target_project ||= (project.forked_from_project || project)
        merge_request.target_branch ||= merge_request.target_project.default_branch
Assignee
Assign to
Time tracking