should "Designs" be "Frames" since that's the Figma terminology and in GitLab we may change "Designs" to something else in the future?
The Figma plugin allows Figma Frames and Components to be uploaded, but we refer to them generally as "Designs" throughout the plugin. This issue is to consider making this more explicit.
Designs
Child items
...
Show closed items
Linked items
0
Link issues together to show that they're related or that one is blocking others.
Learn more.
In the referenced MR the error message was "Upload failed: Designs must have unique names."
In this context we are at the border between Figma and GitLab and the error being returned because GitLab needs the designs to have unique names so the language is not completely wrong.
That said...
When something goes wrong, it’s important for us to be clear about what happened, why it happened, and what the next steps to take may be. Reference
Could I suggest to reword the error message to reflect "what has happened" and change the words to take proactive action towards a resolution.
Suggestion:Unable to upload. Ensure frames/components have unique names.
I am using the word "ensure" rather than "rename" because deselecting something could be the fix to upload only one of the two instead of renaming.
With Figma, anything on the page could be uploaded because most visual elements are SceneNodes (ie. text, layer, group, frame, component, etc). It is an artificial constraint I added at the beginning to ensure that things uploaded should be in a frame or it is a component itself to prevent accidental upload of a small group somewhere when you make a dragged selection of multiple items.
Another way to approach this would be to avoid the words "designs" and "frames/components" and say "Unable to upload. Ensure your selection contains unique names."
Unable to upload. Ensure frames/components have unique names
I don't have an opinion on Unable to upload vs Upload failed, but frames/components reads a lot better to me than designs. I guess it might be worth validating that users are confused about what designs means (although, it's probably a safe assumption that there is ambiguity in the word designs). WDYT @mnearents
@tomquirk, it's not so much that people will be confused by designs. It's more that we don't want to assume people are uploading designs vs diagrams vs graphs, etc. Being agnostic.
In the future, if/when the term designs goes away, then it could be confusing.
Yeah, so the logic here would be that "Designs" is pretty specific and not very inclusive. A developer uploading a flow chart might or might not consider that a design.
@mle it's something we're going to explore. It's been suggested by users that "designs" limits the use of that feature to designers uploading designs. Saying "attachments" would allow developers to upload things too that aren't designs.