Skip to content

Add support for pages bucket

Nick Nguyen requested to merge nhxnguyen-support-pages-bucket into main

What does this MR do?

Adds defaults to support an object storage bucket for GitLab Pages deployments.

Related issues

#408 (closed)

Testing

Tested and verified working on GCP with a 1k Omnibus and 2k hybrid single-site deployment.

Note that to enable Pages, a user will still need to update their gitlab.rb for Omnibus or override the proper Chart values. Supporting a more streamlined way to enable Pages in GET is not currently in the scope of this MR.

Screenshots

Bucket configured in gitlab.rb: pages_bucket_gitlabrb

Pages deployment uploaded to bucket in 1k Omnibus: pages_bucket_content

Pages deployment uploaded to bucket in 2k hybrid: pages_bucket_content_hybrid

Author's checklist

When ready for review, the Author applies the workflowready for review label and mention @gl-quality/get-maintainers:

  • Merge request:
    • Corresponding Issue raised and reviewed by the GET maintainers team.
    • Merge Request Title and Description are up to date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
    • MR has no new security alerts in the widget from the Secret Detection and IaC Scan (SAST) jobs.
  • Code:
    • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
    • Documentation created/updated in the same MR.
    • If this MR adds an optional configuration - check that all permutations continue to work.
    • For Terraform changes: setup a previous version environment, then run a terraform plan with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
  • Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Quality Enablement team if unsure.
Edited by Nick Nguyen

Merge request reports