Skip to content

Add the functionality to set allow_stopping_for_update to false

Vlad Stoianovici requested to merge vlads_allow_stop_for_updates into main

Closes: https://gitlab.com/gitlab-org/quality/gitlab-environment-toolkit/-/issues/198

What does this MR do?

Add the functionality to set allow_stopping_for_update to false. By default it will be set to true.

The reason is that for some VMs there needs to be more sensitivity to restarts like Gitaly, Redis and Postgres and this would be a failsafe for situations where you end up getting caught by surprise with a change that requires a stop and start.

Related issues

https://gitlab.com/gitlab-org/quality/gitlab-environment-toolkit/-/issues/198

Author's checklist

When ready for review, the Author applies the workflowready for review label and mention @gl-quality/get-maintainers:

  • Merge request:
    • Corresponding Issue raised and reviewed by the GET maintainers team.
    • Merge Request Title and Description are up to date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
  • Code:
    • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
    • Documentation created/updated in the same MR.
    • If this MR adds an optional configuration - check that all permutations continue to work.
    • For Terraform changes: setup a previous version environment, then run a terraform plan with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
  • Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Quality Enablement team if unsure.
Edited by Vlad Stoianovici

Merge request reports