Skip to content

Update header format for GitLab Deb Download url

Nailia Iskhakova requested to merge fix-gitlab-deb-download-headers-format into master

What does this MR do?

Headers in get_url support hash/dict format from Ansible 2.6 and string format was deprecated in 2.10. The MR updates headers default string to dictionary to resolve the error below:

TASK [common : Download GitLab deb package] ******************************************************************************************************************
fatal: [staging-ref-10k-gitlab-rails-1]: FAILED! => changed=false 
  msg: 'argument ''headers'' is of type <class ''str''> and we were unable to convert to dict: dictionary requested, could not parse JSON or key=value'

Related issues

Author's checklist

When ready for review, the Author applies the workflowready for review label and mention @gl-quality/get-maintainers:

  • Merge request:
    • Merge Request Title and Description are up to date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
  • Code:
    • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
      • Verified the change against 1k environment
Edited by Nailia Iskhakova

Merge request reports