Skip to content

Adds type/prefix networking tags to all instances

John Jarvis requested to merge jarv/add-type-prefix into master

What does this MR do?

This is a replacement for https://gitlab.com/gitlab-org/quality/gitlab-environment-toolkit/-/merge_requests/322, which only sets tags for consul. Instead, here we set prefix/type tags for all instances.

This is probably the better approach, unless we can think of a reason not to set these tags.

For https://gitlab.com/gitlab-org/quality/gitlab-environment-toolkit/-/issues/256

Related issues

Author's checklist

When ready for review, the Author applies the workflowready for review label:

  • Merge request:
    • Corresponding Issue raised and reviewed by the GET maintainers team.
    • Merge Request Title and Description are up to date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
  • Code:
    • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
    • Documentation created/updated in the same MR.
    • If this MR adds an optional configuration - check that all permutations continue to work.
    • For Terraform changes: setup a previous version environment, then run a terraform plan with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
  • Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Quality Enablement team if unsure.
Edited by John Jarvis

Merge request reports