feat: add tags to the container node pool, to allow SSH on them

Tarun Khandelwalrequested to merge
add-prefix-tag-to-node-pools into main

What does this MR do?

Adds the tags field in the node_config for all the container node pool config sections.

This is required so they can become part of the network firewall rule for SSH, which targets the node based on the tags.

We require this so, we can SSH into the Cell nodes through the IAP Tunnel, see the discovery thread: gitlab-com/gl-infra/production-engineering#26258 (comment 2405568321)

Related issues

Part of: gitlab-com/gl-infra/production-engineering#26258 (closed)

Author's checklist

When ready for review, the Author applies the workflowready for review label and mention @gitlab-org/software-delivery/get-maintainers:

  • Merge request:
    • Corresponding Issue raised and reviewed by the GET maintainers team.
    • Merge Request Title and Description are up-to-date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
    • MR has no new security alerts in the widget from the Secret Detection and IaC Scan (SAST) jobs.
  • Code:
    • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
    • Documentation created/updated in the same MR.
    • If this MR adds an optional configuration - check that all permutations continue to work.
    • For Terraform changes: set up a previous version environment, then run a terraform plan with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
  • Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Framework team if unsure.

Merge request reports