Skip to content

Update Ansible Galaxy roles to work offline as well as pin node exporter calls

Grant Young requested to merge gy-pin-third-party-node-exporter-version into main

What does this MR do?

MR updates the Ansible Galaxy role calls accordingly:

  • geerlingguy.node_exporter and geerlingguy.docker are now no longer attempted when offline_setup has been defined unless specific variables are passed to configure them to work locally.
  • geerlingguy.node_exporter version is now pinned to disable GitHub API checks for latest version, which is subject to rate limits as well as general flakiness.

Closes #860 (closed)

Author's checklist

When ready for review, the Author applies the workflowready for review label and mention @gl-quality/get-maintainers:

  • Merge request:
    • Corresponding Issue raised and reviewed by the GET maintainers team.
    • Merge Request Title and Description are up-to-date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
    • MR has no new security alerts in the widget from the Secret Detection and IaC Scan (SAST) jobs.
  • Code:
    • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
    • Documentation created/updated in the same MR.
    • If this MR adds an optional configuration - check that all permutations continue to work.
    • For Terraform changes: set up a previous version environment, then run a terraform plan with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
  • Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Quality Enablement team if unsure.
Edited by Grant Young

Merge request reports