Skip to content

chore: adds gitaly_node helper var in ansible to consolidate the 'gitaly-#' pattern

Brittany Wilkerson requested to merge bw/gitaly-node-helper-var into main

What does this MR do?

This is a simplifying style change to consolidate referring to the Gitaly node as a whole variable instead of the in-place concatenated gitaly-#.

Added because it made the related MR (https://gitlab.com/gitlab-com/gl-infra/gitlab-dedicated/instrumentor/-/merge_requests/2562) easier for @troblot to implement.

Related issues

Related to https://gitlab.com/gitlab-com/gl-infra/gitlab-dedicated/instrumentor/-/merge_requests/2562

Author's checklist

When ready for review, the Author applies the workflowready for review label and mention @gl-quality/get-maintainers:

  • Merge request:
    • Corresponding Issue raised and reviewed by the GET maintainers team.
    • Merge Request Title and Description are up-to-date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
    • MR has no new security alerts in the widget from the Secret Detection and IaC Scan (SAST) jobs.
  • Code:
    • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
    • Documentation created/updated in the same MR.
    • If this MR adds an optional configuration - check that all permutations continue to work.
    • For Terraform changes: set up a previous version environment, then run a terraform plan with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
  • Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Quality Enablement team if unsure.

Testing

Ran a full deployment of 3k on GCP, with and without Praefect. Validated that the storages all appeared as expected in the admin UI, spot-checked a config on gitaly-2, and created a new repo + readme successfully.

Edited by Brittany Wilkerson

Merge request reports