Skip to content

Handle incoming Sidekiq concurrency deprecation changes

Grant Young requested to merge gy-update-sidekiq-concurrency-config into main

What does this MR do?

MR handles the incoming deprecation changes around Sidekiq concurrency config in 17.0 where max_concurrency and min_concurrency are to be removed.

We had to set this previously as Sidekiq concurrency was too high at 50. However in 15.7 this was reduced to 20 so we no longer need to set this for later releases. As such, MR adjusts setting the old setting only on 15.7 and lower.

Related issues

Relates #832 (closed)

Author's checklist

When ready for review, the Author applies the workflowready for review label and mention @gl-quality/get-maintainers:

  • Merge request:
    • Corresponding Issue raised and reviewed by the GET maintainers team.
    • Merge Request Title and Description are up-to-date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
    • MR has no new security alerts in the widget from the Secret Detection and IaC Scan (SAST) jobs.
  • Code:
    • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
    • Documentation created/updated in the same MR.
    • If this MR adds an optional configuration - check that all permutations continue to work.
    • For Terraform changes: set up a previous version environment, then run a terraform plan with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
  • Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Quality Enablement team if unsure.
Edited by Grant Young

Merge request reports