Skip to content

Draft: Backported CMEK changes for GCP dedicated

Konst Tchernov requested to merge feat/gcp_dedicated_changes into support/3.0.x

What does this MR do?

A temporary branch for vendoring in GCP CMEK features for the GitLab Dedicated project.

Two original GET MRs are included:

Related issues

https://gitlab.com/gitlab-com/gl-infra/gitlab-dedicated/team/-/issues/3846

Author's checklist

WIP: Backport of MRs from 3.1.1 back to 3.0.2, as required for GCP dedicated.

When ready for review, the Author applies the workflowready for review label and mention @gl-quality/get-maintainers:

  • Merge request:
    • Corresponding Issue raised and reviewed by the GET maintainers team.
    • Merge Request Title and Description are up-to-date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
    • MR has no new security alerts in the widget from the Secret Detection and IaC Scan (SAST) jobs.
    • Code:
      • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
      • Documentation created/updated in the same MR.
      • If this MR adds an optional configuration - check that all permutations continue to work.
      • For Terraform changes: set up a previous version environment, then run a terraform plan with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
  • Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Quality Enablement team if unsure.
Edited by Konst Tchernov

Merge request reports