Skip to content

Add var to accept Pages SSL cert/key value directly, enabling embedding from secrets managers

Brittany Wilkerson requested to merge bw/allow-direct-pages-ssl-value into main

What does this MR do?

Move the lookup('file', path) logic out of the gitlab_charts role, so that the secret creation for Pages SSL certs can work with a direct value. This enables passing the secret directly from a secret manager, without an intermediary file (from a file is still supported).

Related issues

Related to Move Ansible lookup-from-file usage for certs i... (#827) • Unassigned

Author's checklist

When ready for review, the Author applies the workflowready for review label and mention @gl-quality/get-maintainers:

  • Merge request:
    • Corresponding Issue raised and reviewed by the GET maintainers team.
    • Merge Request Title and Description are up-to-date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
    • MR has no new security alerts in the widget from the Secret Detection and IaC Scan (SAST) jobs.
  • Code:
    • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
    • Documentation created/updated in the same MR.
    • If this MR adds an optional configuration - check that all permutations continue to work.
    • For Terraform changes: set up a previous version environment, then run a terraform plan with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
  • Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Quality Enablement team if unsure.
Edited by Brittany Wilkerson

Merge request reports