Skip to content

Fix AWS S3 replication for KMS

Grant Young requested to merge gy-aws-s3-kms-replication-fix into main

What does this MR do?

MR fixes AWS S3 replication for Geo when specified KMS keys are being used (SSE-KMS). Missing permissions blocked this from working compared to the default encryption method (SSE-S3).

This is an area of nuance to say the least with numerous permission permutations abound depending specifically on the set up that is split up across multiple pieces of documentation (this troubleshooting doc proved most useful). For our set up where we have S3 Bucket Keys enabled the correct additional permissions are now added accordingly when KMS keys are being used.

Related issues

Closes #345 (closed)

Author's checklist

When ready for review, the Author applies the workflowready for review label and mention @gl-quality/get-maintainers:

  • Merge request:
    • Corresponding Issue raised and reviewed by the GET maintainers team.
    • Merge Request Title and Description are up-to-date, accurate, and descriptive
    • MR targeting the appropriate branch
    • MR has a green pipeline
    • MR has no new security alerts in the widget from the Secret Detection and IaC Scan (SAST) jobs.
  • Code:
    • Check the area changed works as expected. Consider testing it in different environment sizes (1k,3k,10k,etc.).
    • Documentation created/updated in the same MR.
    • If this MR adds an optional configuration - check that all permutations continue to work.
    • For Terraform changes: set up a previous version environment, then run a terraform plan with your new changes and ensure nothing will be destroyed. If anything will be destroyed and this can't be avoided please add a comment to the current MR.
  • Create any follow-up issue(s) to support the new feature across other supported cloud providers or advanced configurations. Create 1 issue for each provider/configuration. Contact the Quality Enablement team if unsure.
Edited by Grant Young

Merge request reports