Update deprecated linters and fix icu for linter image

Terri Churequested to merge
tchu-check-golang-ci-linter into main
  • Replace varcheck, deadcode, and stuctcheck with unused
  • Update linter pipeline to install icu. Originally it was reported as a warning but about being unable to load the icu package. We found that it actually prevented the linter from reporting issues
  • Increase linter timeout to 2 minutes, default is 1 minute and now it's taking just over 1 minute to run
  • Fix linter error now that linter is working correctly this was resolved in another branch which got merged before this MR

example pipeline: https://gitlab.com/gitlab-org/gitlab-elasticsearch-indexer/-/jobs/4026632895

example warning

level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package icu: could not load export data: no export data for \"gitlab.com/lupine/icu\""

note: future iteration to add custom linter yml and use the standard image from the documentation will be handled in #117

Edited by Terri Chu

Merge request reports