Project 'gitlab-org/gitlab-ee' was moved to 'gitlab-org/gitlab'. Please update any links and bookmarks that may still have the old path.
Resolve "Add "No approval required" state to approval rules MR component"
What does this MR do?
The previous implementation of multiple blocking approval rules #1979 (closed) did not include the "No approvals required" view. This MR adds this feature to the new set of MR widget approvals components.
Please note:
To test this feature you will need to enable the feature flag approval_rules
.
What are the relevant issue numbers?
Closes #9963 (closed)
Screenshots
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
Link to e2e tests MR added if this MR has Requires e2e tests label. See the Test Planning Process. -
EE specific content should be in the top level /ee
folder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan? -
Security reports checked/validated by reviewer
Edited by Paul Slaughter
Merge request reports
Activity
Please register or sign in to reply