Skip to content
Snippets Groups Projects

Resolve "Add "No approval required" state to approval rules MR component"

Merged Paul Slaughter requested to merge 9963-optional-approval-view into master

What does this MR do?

The previous implementation of multiple blocking approval rules #1979 (closed) did not include the "No approvals required" view. This MR adds this feature to the new set of MR widget approvals components.

Please note:

To test this feature you will need to enable the feature flag approval_rules.

What are the relevant issue numbers?

Closes #9963 (closed)

Screenshots

Screen_Shot_2019-03-06_at_2.15.33_PM

Does this MR meet the acceptance criteria?

Edited by Paul Slaughter

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sam Bigelow
  • This looks good to me! :thumbsup: Just curious about the one empty spec.

  • @pslaughter I was thinking about this later and wanted to give it some more attention. At a better look, I basically just noticed some places that could use more null checking. This lead me to thinking it may be worth just a computed approvals property that could default values on this.mr.approvals if it is undefined.

    I could be off here, so they are just mentioned as questions.

  • Paul Slaughter added 3 commits

    added 3 commits

    • 93dbab4c - Add approvals summary optional component
    • 273f28f3 - Fix use of deprecated hasClass in spec
    • 07703c65 - Add default approvals obj to rules mr component

    Compare with previous version

  • Paul Slaughter added 1 commit

    added 1 commit

    • ef2a70ae - Add default approvals obj to rules mr component

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading