Make Geo::PruneEventLogWorker delete rows more gently
What does this MR do?
Instead of attempting to delete all rows in a single SQL query, do it in batches.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Conform by the code review guidelines
-
Has been reviewed by a UX Designer -
Has been reviewed by a Frontend maintainer -
Has been reviewed by a Backend maintainer -
Has been reviewed by a Database specialist
-
-
EE specific content should be in the top level /ee
folder -
Conform by the merge request performance guides -
Conform by the style guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them -
Internationalization required/considered -
If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan -
End-to-end tests pass ( package-qa
manual pipeline job)
What are the relevant issue numbers?
Closes gitlab-org/gitlab-ee#6140.
Merge request reports
Activity
marked the checklist item Changelog entry added, if necessary as completed
added 1 commit
- cedf4654 - Make Geo::PruneEventLogWorker delete rows more gently
marked the checklist item Documentation created/updated as completed
marked the checklist item Conform by the merge request performance guides as completed
marked the checklist item Conform by the style guides as completed
marked the checklist item If you have multiple commits, please combine them into a few logically organized commits by squashing them as completed
@stanhu Can you please review? And does it makes sense to pick this into 11.x?
assigned to @stanhu
- Resolved by Toon Claes
@toon Thanks! Just one question, but looks good to me.
assigned to @toon
assigned to @stanhu
mentioned in commit 0f073e7b
mentioned in issue #6221 (closed)
Picked into https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5892, will merge into
10-8-stable-ee
ready for10.8.3-ee
mentioned in commit cab2d1de
mentioned in issue gitlab-org/release/tasks#247 (closed)
changed milestone to %10.8
mentioned in issue gitlab-com/migration#772 (closed)
added devopssystems groupgeo labels
added Enterprise Edition label