Skip to content
Snippets Groups Projects

Make Geo::PruneEventLogWorker delete rows more gently

Merged Toon Claes requested to merge tc-geo-gently-log-prune into master
All threads resolved!

What does this MR do?

Instead of attempting to delete all rows in a single SQL query, do it in batches.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a UX Designer
    • Has been reviewed by a Frontend maintainer
    • Has been reviewed by a Backend maintainer
    • Has been reviewed by a Database specialist
  • EE specific content should be in the top level /ee folder
  • Conform by the merge request performance guides
  • Conform by the style guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Closes gitlab-org/gitlab-ee#6140.

Edited by Toon Claes

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Toon Claes marked the checklist item Changelog entry added, if necessary as completed

    marked the checklist item Changelog entry added, if necessary as completed

  • Toon Claes added 1 commit

    added 1 commit

    • cedf4654 - Make Geo::PruneEventLogWorker delete rows more gently

    Compare with previous version

  • Toon Claes marked the checklist item Documentation created/updated as completed

    marked the checklist item Documentation created/updated as completed

  • Toon Claes marked the checklist item API support added as completed

    marked the checklist item API support added as completed

  • Toon Claes marked the checklist item Tests added for this feature/bug as completed

    marked the checklist item Tests added for this feature/bug as completed

  • Toon Claes marked the checklist item Has been reviewed by a UX Designer as completed

    marked the checklist item Has been reviewed by a UX Designer as completed

  • Toon Claes marked the checklist item Has been reviewed by a Frontend maintainer as completed

    marked the checklist item Has been reviewed by a Frontend maintainer as completed

  • Toon Claes marked the checklist item EE specific content should be in the top level /ee folder as completed

    marked the checklist item EE specific content should be in the top level /ee folder as completed

  • Toon Claes marked the checklist item Conform by the merge request performance guides as completed

    marked the checklist item Conform by the merge request performance guides as completed

  • Toon Claes marked the checklist item Conform by the style guides as completed

    marked the checklist item Conform by the style guides as completed

  • Toon Claes marked the checklist item If you have multiple commits, please combine them into a few logically organized commits by squashing them as completed

    marked the checklist item If you have multiple commits, please combine them into a few logically organized commits by squashing them as completed

  • Toon Claes marked the checklist item Internationalization required/considered as completed

    marked the checklist item Internationalization required/considered as completed

  • Toon Claes marked the checklist item End-to-end tests pass (package-qa manual pipeline job) as completed

    marked the checklist item End-to-end tests pass (package-qa manual pipeline job) as completed

  • Toon Claes marked the checklist item End-to-end tests pass (package-qa manual pipeline job) as incomplete

    marked the checklist item End-to-end tests pass (package-qa manual pipeline job) as incomplete

  • Toon Claes marked the checklist item If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan as completed

    marked the checklist item If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan as completed

  • Toon Claes marked the checklist item End-to-end tests pass (package-qa manual pipeline job) as completed

    marked the checklist item End-to-end tests pass (package-qa manual pipeline job) as completed

  • Author Maintainer

    @stanhu Can you please review? And does it makes sense to pick this into 11.x?

  • assigned to @stanhu

  • Toon Claes changed the description

    changed the description

  • Stan Hu
  • @toon Thanks! Just one question, but looks good to me.

  • assigned to @toon

  • assigned to @stanhu

  • Stan Hu resolved all discussions

    resolved all discussions

  • Stan Hu approved this merge request

    approved this merge request

  • merged

  • Stan Hu mentioned in commit 0f073e7b

    mentioned in commit 0f073e7b

  • Toon Claes resolved all discussions

    resolved all discussions

  • mentioned in issue #6221 (closed)

  • Picked into https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5892, will merge into 10-8-stable-ee ready for 10.8.3-ee

  • Stan Hu mentioned in commit cab2d1de

    mentioned in commit cab2d1de

  • Toon Claes changed milestone to %10.8

    changed milestone to %10.8

  • Rachel Nienaber removed 1 deleted label

    removed 1 deleted label

  • Please register or sign in to reply
    Loading