Skip to content

Groups reports in MR view and splits reports in CI view

Filipa Lacerda requested to merge 4310-security-reports-step-2 into master

What does this MR do?

  1. Groups reports in MR view
  2. Splits reports in CI view
  3. Updates texts

Note: There ins't an easy way to test this locally.

Apply these diffs:

  1. For errors: error.diff
  2. For loading: loading.diff
  3. For success: success.diff
  4. For no base: nobase.diff

Screenshots (if relevant)

Note: The copy in the screenshots in not up to date. Check the code with the copy instead

CI View

Scroll: https://cl.ly/2A3s1f253U2O

Screen_Shot_2018-03-26_at_20.38.57 Screen_Shot_2018-03-26_at_20.37.56 Screen_Shot_2018-03-26_at_21.03.03 Screen_Shot_2018-03-26_at_21.03.09 Screen_Shot_2018-03-26_at_21.03.14

MR widget

alignment

Error

all_failed_summary all_failed_expanded all_failed_expanded_popover

Loading

all_loading_collapsed all_loading_expanded

All states

all_states_collapsed all_states_expanded

Success with vulnerabilities

all_success_with_collapsed all_success_with_expanded

Success without vulnerabilities

all_success_collapsed all_success_no_vulnerabilities_expanded

No base

Screen_Shot_2018-04-02_at_14.56.27 Screen_Shot_2018-04-02_at_14.50.26

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #4310 (closed) Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/5105 Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/4464 Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/5129

Edited by Dimitrie Hoekstra

Merge request reports