Allow to configure Jira api URL

Cf. support request 2829

Provide a property api_url for JiraService in order to customize the API path. This is necessary if for instance Jira is not installed at the root of the web server. For user convenience, the API URL is automatically built from the Project URL using the same logic as before, so that it shouldn't be necessary for users to actually enter the API URL in most cases.

Remove the api_version property which seems redundant with the API URL. A DB migration removes api_version and initializes the API URL from project_url and api_version using the same logic as before for a seamless transition.

Added 1 commit:

• 22b2e3c6 - Allow configuring the Jira API URL

Added 11 commits:

• 22b2e3c6...ace64666 - 7 commits from branch gitlab-org:master
• f66fa56d - Invalidate stored service password if the endpoint URL is changed
• 8d7a3b3a - Hide password in the service settings form
• ca028627 - Improve invalidation of stored service password if the endpoint URL is changed
• c027f4f7 - Allow configuring the Jira API URL

Added 723 commits:

• c027f4f7...2d7be2d4 - 722 commits from branch gitlab-org:master
• fe5b9a1a - Allow configuring the Jira API URL

Title changed from [WIP] Allow to configure Jira api URL to Allow to configure Jira api URL

Rebased after merge of CE code with EE and removed WIP tag.

Added 3 commits:

• fe5b9a1a...01c027e5 - 2 commits from branch gitlab-org:master
• 185cc31d - Allow configuring the Jira API URL

Reassigned to @marin

Milestone changed to 8.2

@marin In this proposal I tried not to increase the number of properties, but another possible implementation could keep api_version and add another property api_server_url to provide the base URL for the API (e.g. https://jira.example.com/ or https://jira.example.com/jira_root_path), and then we'd build the full API URL from both. The DB migration could then initialize api_server_url from project_url. Please let me know what you think.

Cross link to Zendesk: https://gitlab.zendesk.com/agent/tickets/7395

FYI https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/38

Added 7 commits:

• 185cc31d...1296d965 - 6 commits from branch gitlab-org:master
• 6040ddf2 - Allow configuring the Jira API URL

OK, rebased on !38 (merged)

@marin any feedback on this proposal?

We badly need to support our Jira installations outside the webserver root at last (this has been pending since May, cf. https://gitlab.zendesk.com/hc/requests/2829). There are other reasons why we find it interesting to decouple the Jira API URL from the project_url, for instance to enable our users to freely decide where GitLab sends when clicking the 'Issues' link (i.e. project_url) without affecting the API endpoint for Jira integration -- it certainly seems strange to have those two URLs correlated like now.

I plan to deploy this patch with our upgrade to 8.1 and it would be great if we could have confirmation that the proposal makes sense and you agree on the general direction it's taking, i.e. have a separate setting for the Jira API URL (even if more work is needed before it's merged). I'd prefer to make sure upstream is going to follow the same direction eventually.

Thanks in advance!

@cernvcs Sorry for not responding sooner, trying to get trough my inbox.

Added 252 commits:

• 6040ddf2...0528ac63 - 251 commits from branch gitlab-org:master
• 9d14892e - Allow configuring the Jira API URL

@marin thanks for the review, here's an update taking comments about the DB migration into account