Skip to content
Snippets Groups Projects

Only rename the column if its not there yet

Merged Zeger-Jan van de Weg requested to merge upgrade-ce-ee-migration-error-fix into master

The problem can only arise when upgrading from a CE version to an EE version after last months release as in that release the table appearances was created. But when it was created we already took care of this rename. Thus on an upgrade the migration will fail as the column light_logo is not in the table, and header_logo already is.

Thus this check solves it.

@dblessing @DouweM

BTW; should be included in the current release and the previous.

Fixes #406 (closed)

Merge request reports

Pipeline #998499 passed with warnings

Pipeline passed with warnings for c9bb130b on upgrade-ce-ee-migration-error-fix

Approval is optional

Merged by avatar (Feb 23, 2025 6:59am UTC)

Merge details

Pipeline #1004295 passed with warnings

Pipeline passed with warnings for 89e82697 on master

4 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Added 1 commit:

    • 6dcf9bc6 - Only rename the column if its not there yet
  • Added 1 commit:

    • c9bb130b - Only rename the column if its not there yet
  • @dblessing What is the best way to test this?

  • Rémy Coutable Milestone changed to 8.6

    Milestone changed to 8.6

  • Rémy Coutable Added ~149424 label

    Added ~149424 label

  • I've created a new dev kit, edited the Makefile to checkout v8.5.3 and ran make. Than followed the upgrade guide for source installations.

    2.1.8 :002 > ActiveRecord::Migrator.current_version
      ActiveRecord::SchemaMigration Load (0.3ms)  SELECT "schema_migrations".* FROM "schema_migrations"
     => 20160222153918

    rake db:migrate

    ─zegerjan@Zeger-Jans-MBP.lan ~/test/gitlab-development-kit/gitlab ‹ruby-2.1.8› ‹8-6-stable-ee›
    ╰─➤  rake db:migrate
    Instance method "run" is already defined in Object, use generic helper instead or set StateMachines::Machine.ignore_method_conflicts = true.
    == 20130711063759 CreateProjectGroupLinks: migrating ==========================
    -- create_table(:project_group_links)
       -> 0.0151s
    == 20130711063759 CreateProjectGroupLinks: migrated (0.0152s) =================
    
    == 20130802124933 AddLdapSettingsToGroup: migrating ===========================
    -- add_column(:namespaces, :ldap_cn, :string, {:null=>true})
       -> 0.0021s
    == 20130802124933 AddLdapSettingsToGroup: migrated (0.0022s) ==================
    
    == 20130809090140 AddLdapAccessToGroup: migrating =============================
    -- add_column(:namespaces, :ldap_access, :integer, {:null=>true})
       -> 0.0007s
    == 20130809090140 AddLdapAccessToGroup: migrated (0.0008s) ====================
    
    == 20130820102832 AddAccessToProjectGroupLink: migrating ======================
    -- add_column(:project_group_links, :group_access, :integer, {:null=>false, :default=>30})
       -> 0.0052s
    == 20130820102832 AddAccessToProjectGroupLink: migrated (0.0144s) =============
    
    == 20140319135450 CreateGitHooks: migrating ===================================
    -- create_table(:git_hooks)
       -> 0.0053s
    == 20140319135450 CreateGitHooks: migrated (0.0054s) ==========================
    
    == 20140414093351 CreateAppearances: migrating ================================
    -- table_exists?(:appearances)
       -> 0.0017s
    == 20140414093351 CreateAppearances: migrated (0.0019s) =======================
    
    == 20140508105809 AddMrTemplateToProject: migrating ===========================
    -- add_column(:projects, :merge_requests_template, :text)
       -> 0.0012s
    == 20140508105809 AddMrTemplateToProject: migrated (0.0013s) ==================
    
    == 20140513095908 AddUsernamePasswordApiVersionToServices: migrating ==========
    -- add_column(:services, :username, :string)
       -> 0.0010s
    -- add_column(:services, :password, :string)
       -> 0.0006s
    -- add_column(:services, :api_version, :string)
       -> 0.0005s
    == 20140513095908 AddUsernamePasswordApiVersionToServices: migrated (0.0022s) =
    
    == 20140811083829 AddUnsubscribedAtFieldToUsers: migrating ====================
    -- add_column(:users, :admin_email_unsubscribed_at, :datetime)
       -> 0.0009s
    == 20140811083829 AddUnsubscribedAtFieldToUsers: migrated (0.0010s) ===========
    
    == 20140811155127 AddJiraIssueTransitionIdToServices: migrating ===============
    -- add_column(:services, :jira_issue_transition_id, :string, {:default=>"2"})
       -> 0.0140s
    == 20140811155127 AddJiraIssueTransitionIdToServices: migrated (0.1484s) ======
    
    == 20140813090117 AddLdapGroupsTable: migrating ===============================
    -- create_table(:ldap_groups)
       -> 0.0037s
    == 20140813090117 AddLdapGroupsTable: migrated (0.0038s) ======================
    
    == 20140813133925 RenameLdapGroupToLdapGroupLink: migrating ===================
    -- rename_table(:ldap_groups, :ldap_group_links)
       -> 0.0107s
    -- execute("INSERT INTO ldap_group_links ( group_access, cn, group_id, created_at, updated_at )\n             SELECT ldap_access, ldap_cn, id, DATE('2016-03-23 10:42:42'), DATE('2016-03-23 10:42:42') FROM namespaces\n             WHERE ldap_cn IS NOT NULL;")
       -> 0.0055s
    == 20140813133925 RenameLdapGroupToLdapGroupLink: migrated (0.0165s) ==========
    
    == 20140907223153 RemoveColumnsForServices: migrating =========================
    -- remove_column(:services, :username, :string)
       -> 0.0010s
    -- remove_column(:services, :password, :string)
       -> 0.0005s
    -- remove_column(:services, :jira_issue_transition_id, :string)
       -> 0.0011s
    -- remove_column(:services, :api_version, :string)
       -> 0.0007s
    == 20140907223153 RemoveColumnsForServices: migrated (0.0036s) ================
    
    == 20141010132608 AddProviderToLdapGroupLinks: migrating ======================
    -- add_column(:ldap_group_links, :provider, :string)
       -> 0.0011s
    == 20141010132608 AddProviderToLdapGroupLinks: migrated (0.0012s) =============
    
    == 20141027173526 AddAuthorEmailRegexToGitHook: migrating =====================
    -- add_column(:git_hooks, :author_email_regex, :string)
       -> 0.0008s
    == 20141027173526 AddAuthorEmailRegexToGitHook: migrated (0.0009s) ============
    
    == 20141030133853 AddMemberCheckToGitHooks: migrating =========================
    -- add_column(:git_hooks, :member_check, :boolean, {:default=>false, :null=>false})
       -> 0.0065s
    == 20141030133853 AddMemberCheckToGitHooks: migrated (0.0066s) ================
    
    == 20141103160516 AddFileNameRegexToGitHooks: migrating =======================
    -- add_column(:git_hooks, :file_name_regex, :string)
       -> 0.0006s
    == 20141103160516 AddFileNameRegexToGitHooks: migrated (0.0007s) ==============
    
    == 20141126120926 AddMergeRequestRebaseEnabledToProjects: migrating ===========
    -- add_column(:projects, :merge_requests_rebase_enabled, :boolean, {:default=>false})
       -> 0.0237s
    == 20141126120926 AddMergeRequestRebaseEnabledToProjects: migrated (0.0238s) ==
    
    == 20141212124604 AddGroupMembershipLock: migrating ===========================
    -- add_column(:namespaces, :membership_lock, :boolean, {:default=>false})
       -> 0.0161s
    == 20141212124604 AddGroupMembershipLock: migrated (0.0162s) ==================
    
    == 20141213212220 AddHeaderLogosToAppearances: migrating ======================
    -- add_column(:appearances, :dark_logo, :string)
       -> 0.0018s
    -- add_column(:appearances, :light_logo, :string)
       -> 0.0006s
    == 20141213212220 AddHeaderLogosToAppearances: migrated (0.0027s) =============
    
    == 20141230100055 RemoveOldFieldsFromNamespace: migrating =====================
    -- remove_column(:namespaces, :ldap_cn)
       -> 0.0007s
    -- remove_column(:namespaces, :ldap_access)
       -> 0.0006s
    == 20141230100055 RemoveOldFieldsFromNamespace: migrated (0.0015s) ============
    
    == 20150125163158 AddRebaseSettingToProjects: migrating =======================
    -- add_column(:projects, :merge_requests_rebase_default, :boolean, {:default=>true})
       -> 0.0168s
    == 20150125163158 AddRebaseSettingToProjects: migrated (0.0171s) ==============
    
    == 20150225214822 HelpTextToApplicationSettings: migrating ====================
    -- add_column(:application_settings, :help_text, :text)
       -> 0.0007s
    == 20150225214822 HelpTextToApplicationSettings: migrated (0.0008s) ===========
    
    == 20150312000132 AddGroupIdToWebHooks: migrating =============================
    -- add_column(:web_hooks, :group_id, :integer, {:after=>:project_id})
       -> 0.0012s
    == 20150312000132 AddGroupIdToWebHooks: migrated (0.0013s) ====================
    
    == 20150324223425 AddIsSampleToGitHooks: migrating ============================
    -- add_column(:git_hooks, :is_sample, :boolean, {:default=>false})
       -> 0.0103s
    == 20150324223425 AddIsSampleToGitHooks: migrated (0.0104s) ===================
    
    == 20150501095306 CreateLicenses: migrating ===================================
    -- create_table(:licenses)
       -> 0.0057s
    == 20150501095306 CreateLicenses: migrated (0.0058s) ==========================
    
    == 20150507194350 CreateHistoricalData: migrating =============================
    -- create_table(:historical_data)
       -> 0.0068s
    == 20150507194350 CreateHistoricalData: migrated (0.0069s) ====================
    
    == 20150605131047 AddMaxFileSizeToGitHooks: migrating =========================
    -- add_column(:git_hooks, :max_file_size, :integer, {:default=>0})
       -> 0.0073s
    == 20150605131047 AddMaxFileSizeToGitHooks: migrated (0.0074s) ================
    
    == 20150609113337 CreateApproves: migrating ===================================
    -- create_table(:approvals)
       -> 0.0040s
    == 20150609113337 CreateApproves: migrated (0.0041s) ==========================
    
    == 20150609125332 AddProjectMergeApproves: migrating ==========================
    -- add_column(:projects, :approvals_before_merge, :integer, {:null=>false, :default=>0})
       -> 0.0268s
    == 20150609125332 AddProjectMergeApproves: migrated (0.0269s) =================
    
    == 20150707222220 AddApproversTable: migrating ================================
    -- create_table(:approvers)
       -> 0.0194s
    == 20150707222220 AddApproversTable: migrated (0.0196s) =======================
    
    == 20150709134649 AddResetApproversToProject: migrating =======================
    -- add_column(:projects, :reset_approvers_on_push, :boolean, {:default=>true})
       -> 0.0180s
    == 20150709134649 AddResetApproversToProject: migrated (0.0183s) ==============
    
    == 20150717155058 RenameResetApprovers: migrating =============================
    -- rename_column(:projects, :reset_approvers_on_push, :reset_approvals_on_push)
       -> 0.0150s
    == 20150717155058 RenameResetApprovers: migrated (0.0152s) ====================
    
    == 20150731200022 RemoveInvalidApprovers: migrating ===========================
    -- execute("DELETE FROM approvers WHERE user_id = 0")
       -> 0.0009s
    == 20150731200022 RemoveInvalidApprovers: migrated (0.0010s) ==================
    
    == 20150827121444 AddFastForwardOptionToProject: migrating ====================
    -- add_column(:projects, :merge_requests_ff_only_enabled, :boolean, {:default=>false})
       -> 0.0184s
    == 20150827121444 AddFastForwardOptionToProject: migrated (0.0185s) ===========
    
    == 20150827144737 MigrateRebaseFeature: migrating =============================
    -- execute("UPDATE projects SET merge_requests_ff_only_enabled = TRUE WHERE merge_requests_rebase_enabled IS TRUE")
       -> 0.0015s
    -- remove_column(:projects, :merge_requests_rebase_default)
       -> 0.0010s
    == 20150827144737 MigrateRebaseFeature: migrated (0.0027s) ====================
    
    == 20150929160851 AddIssuesTemplateToProject: migrating =======================
    -- add_column(:projects, :issues_template, :text)
       -> 0.0011s
    == 20150929160851 AddIssuesTemplateToProject: migrated (0.0012s) ==============
    
    == 20150930110012 AddGroupShareLock: migrating ================================
    -- add_column(:namespaces, :share_with_group_lock, :boolean, {:default=>false})
       -> 0.0146s
    == 20150930110012 AddGroupShareLock: migrated (0.0148s) =======================
    
    == 20151007110107 UpdateGroupLinks: migrating =================================
    -- quote_string(nil)
       -> 0.0000s
    -- execute("UPDATE ldap_group_links SET provider = '' WHERE provider IS NULL")
       -> 0.0005s
    == 20151007110107 UpdateGroupLinks: migrated (0.0008s) ========================
    
    == 20151110125416 AddMirrorToProject: migrating ===============================
    -- add_column(:projects, :mirror, :boolean, {:default=>false, :null=>false})
       -> 0.0207s
    -- add_column(:projects, :mirror_last_update_at, :datetime)
       -> 0.0008s
    -- add_column(:projects, :mirror_last_successful_update_at, :datetime)
       -> 0.0010s
    -- add_column(:projects, :mirror_user_id, :integer)
       -> 0.0016s
    == 20151110125416 AddMirrorToProject: migrated (0.0261s) ======================
    
    == 20151113115819 CanonicalizeKerberosIdentities: migrating ===================
    -- quote_string("LAN")
       -> 0.0000s
    -- execute("UPDATE identities SET extern_uid = CONCAT(extern_uid, '@LAN')\n                 WHERE provider = 'kerberos' AND extern_uid NOT LIKE '%@%'")
       -> 0.0031s
    == 20151113115819 CanonicalizeKerberosIdentities: migrated (0.0287s) ==========
    
    == 20151208110020 AddNoteToUsers: migrating ===================================
    -- column_exists?(:users, :note)
       -> 0.0030s
    -- add_column(:users, :note, :text)
       -> 0.0009s
    == 20151208110020 AddNoteToUsers: migrated (0.0041s) ==========================
    
    == 20151209222208 AddWeightToIssue: migrating =================================
    -- add_column(:issues, :weight, :integer)
       -> 0.0015s
    == 20151209222208 AddWeightToIssue: migrated (0.0016s) ========================
    
    == 20151215005729 RenameJenkinsService: migrating =============================
    -- execute("UPDATE services SET type = 'JenkinsDeprecatedService' WHERE type = 'JenkinsService';")
       -> 0.0011s
    == 20151215005729 RenameJenkinsService: migrated (0.0012s) ====================
    
    == 20151215132013 AddPagesSizeToApplicationSettings: migrating ================
    -- add_column(:application_settings, :max_pages_size, :integer, {:default=>100, :null=>false})
       -> 0.0098s
    == 20151215132013 AddPagesSizeToApplicationSettings: migrated (0.0102s) =======
    
    == 20151228203337 ChangeMaxFileSizeToNotNullOnGitHooks: migrating =============
    -- change_column_null(:git_hooks, :max_file_size, false, 0)
       -> 0.0028s
    == 20151228203337 ChangeMaxFileSizeToNotNullOnGitHooks: migrated (0.0029s) ====
    
    == 20160112174440 CreateGeoNodes: migrating ===================================
    -- create_table(:geo_nodes)
       -> 0.0150s
    == 20160112174440 CreateGeoNodes: migrated (0.0151s) ==========================
    
    == 20160119170055 AddMirrorTriggerBuildsToProjects: migrating =================
    -- add_column(:projects, :mirror_trigger_builds, :boolean, {:default=>false, :null=>false})
       -> 0.0122s
    == 20160119170055 AddMirrorTriggerBuildsToProjects: migrated (0.0124s) ========
    
    == 20160129075828 CreateIndexStatuses: migrating ==============================
    -- create_table(:index_statuses)
       -> 0.0060s
    -- add_index(:index_statuses, :project_id, {:unique=>true})
       -> 0.0088s
    == 20160129075828 CreateIndexStatuses: migrated (0.0149s) =====================
    
    == 20160204144558 AddRealSizeToMergeRequestDiffs: migrating ===================
    -- add_column(:merge_request_diffs, :real_size, :string)
       -> 0.0007s
    == 20160204144558 AddRealSizeToMergeRequestDiffs: migrated (0.0008s) ==========
    
    == 20160204190809 UpdateJenkinsServiceCategory: migrating =====================
    -- quote_column_name("category")
       -> 0.0000s
    -- quote_column_name("type")
       -> 0.0000s
    -- execute("UPDATE services\nSET \"category\" = 'ci'\nWHERE \"type\" IN (\n  'JenkinsService',\n  'JenkinsDeprecatedService'\n)\n")
       -> 0.0009s
    == 20160204190809 UpdateJenkinsServiceCategory: migrated (0.0012s) ============
    
    == 20160210105555 CreatePagesDomain: migrating ================================
    -- create_table(:pages_domains)
       -> 0.0073s
    -- add_index(:pages_domains, :domain, {:unique=>true})
       -> 0.0041s
    == 20160210105555 CreatePagesDomain: migrated (0.0116s) =======================
    
    == 20160221013512 AddGeoNodeKeyToGeoNode: migrating ===========================
    -- change_table(:geo_nodes)
       -> 0.0040s
    == 20160221013512 AddGeoNodeKeyToGeoNode: migrated (0.0042s) ==================
    
    == 20160223192159 AddConfidentialToIssues: migrating ==========================
    -- add_column(:issues, :confidential, :boolean, {:default=>false})
       -> 0.0152s
    -- add_index(:issues, :confidential)
       -> 0.0026s
    == 20160223192159 AddConfidentialToIssues: migrated (0.0180s) =================
    
    == 20160225090018 AddDeleteAtToIssues: migrating ==============================
    -- add_column(:issues, :deleted_at, :datetime)
       -> 0.0006s
    -- add_index(:issues, :deleted_at)
       -> 0.0021s
    == 20160225090018 AddDeleteAtToIssues: migrated (0.0029s) =====================
    
    == 20160225101956 AddDeleteAtToMergeRequests: migrating =======================
    -- add_column(:merge_requests, :deleted_at, :datetime)
       -> 0.0006s
    -- add_index(:merge_requests, :deleted_at)
       -> 0.0048s
    == 20160225101956 AddDeleteAtToMergeRequests: migrated (0.0056s) ==============
    
    == 20160226114608 AddTrigramIndexesForSearching: migrating ====================
    -- execute("SELECT true AS enabled FROM pg_available_extensions WHERE name = 'pg_trgm' AND installed_version IS NOT NULL;")
       -> 0.0231s
    rake aborted!
    StandardError: An error has occurred, all later migrations canceled:
    
    You must enable the pg_trgm extension. You can do so by running "CREATE EXTENSION pg_trgm;" as a PostgreSQL super user, this must be done for every GitLab database. For more information see http://www.postgresql.org/docs/current/static/sql-createextension.html/Users/zegerjan/test/gitlab-development-kit/gitlab/db/migrate/20160226114608_add_trigram_indexes_for_searching.rb:8:in `up'
    /Users/zegerjan/test/gitlab-development-kit/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.2.5.2/lib/active_record/migration.rb:611:in `exec_migration'
    <snip>

    Than: again, so I ran into the reported problem :)

    
    == 20160302141317 RenameHeaderFieldOnAppearrance: migrating ===================
    -- rename_column(:appearances, :light_logo, :header_logo)
    rake aborted!
    StandardError: An error has occurred, this and all later migrations canceled:
    
    PG::DuplicateColumn: ERROR:  column "header_logo" of relation "appearances" already exists
    : ALTER TABLE "appearances" RENAME COLUMN "light_logo" TO "header_logo"/Users/zegerjan/test/gitlab-development-kit/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.2.5.2/lib/active_record/connection_adapters/postgresql/database_statements.rb:155:in `async_exec'
    /Users/zegerjan/test/gitlab-development-kit/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.2.5.2/lib/active_record/connection_adapters/postgresql/database_statements.rb:155:in `block in execute'
    /Users/zegerjan/test/gitlab-development-kit/gitlab/vendor/bundle/ruby/2.1.0/gems/activerecord-4.2.5.2/lib/active_record/connection_adapters/abstract_adapter.rb:472:in `block in log'

    Made sure this patch was there:

    ─zegerjan@Zeger-Jans-MBP.lan ~/test/gitlab-development-kit/gitlab ‹ruby-2.1.8› ‹8-6-stable-ee›
    ╰─➤  rake db:migrate                                                                                              1 ↵
    Instance method "run" is already defined in Object, use generic helper instead or set StateMachines::Machine.ignore_method_conflicts = true.
    == 20160302141317 RenameHeaderFieldOnAppearrance: migrating ===================
    -- column_exists?(:appearances, :header_logo)
       -> 0.0009s
    -- column_exists?(:appearances, :dark_logo)
       -> 0.0008s
    -- remove_column(:appearances, :dark_logo)
       -> 0.0007s
    == 20160302141317 RenameHeaderFieldOnAppearrance: migrated (0.0025s) ==========
    
    == 20160303210802 AddSecondaryExternUidToIdentities: migrating ================
    -- add_column(:identities, :secondary_extern_uid, :string)
       -> 0.0008s
    == 20160303210802 AddSecondaryExternUidToIdentities: migrated (0.0008s) =======
    
    == 20160305220806 RemoveExpiresAtFromSnippets: migrating ======================
    -- remove_column(:snippets, :expires_at, :datetime)
       -> 0.0007s
    == 20160305220806 RemoveExpiresAtFromSnippets: migrated (0.0007s) =============
    
    == 20160307221555 DisallowBlankLineCodeOnNote: migrating ======================
    -- execute("UPDATE notes SET line_code = NULL WHERE line_code = ''")
       -> 0.0041s
    == 20160307221555 DisallowBlankLineCodeOnNote: migrated (0.0042s) =============
    
    == 20160308212903 AddDefaultGroupVisibilityToApplicationSettings: migrating ===
    -- add_column(:application_settings, :default_group_visibility, :integer)
       -> 0.0006s
    -- select_one("SELECT restricted_visibility_levels FROM application_settings ORDER BY id DESC LIMIT 1")
       -> 0.0004s
    -- execute("UPDATE application_settings SET default_group_visibility = 20")
       -> 0.0004s
    == 20160308212903 AddDefaultGroupVisibilityToApplicationSettings: migrated (0.0016s)
    
    == 20160309140734 FixTodos: migrating =========================================
    -- execute("      DELETE FROM todos\n      WHERE todos.target_type IN ('Commit', 'ProjectSnippet')\n         OR NOT EXISTS (\n              SELECT *\n              FROM projects\n              WHERE projects.id = todos.project_id\n            )\n")
       -> 0.0061s
    == 20160309140734 FixTodos: migrated (0.0062s) ================================
    
    == 20160310185910 AddExternalFlagToUsers: migrating ===========================
    -- add_column(:users, :external, :boolean, {:default=>false})
       -> 0.0357s
    == 20160310185910 AddExternalFlagToUsers: migrated (0.0359s) ==================
    
    == 20160314143402 ProjectsAddPushesSinceGc: migrating =========================
    -- add_column(:projects, :pushes_since_gc, :integer, {:default=>0})
       -> 0.0250s
    == 20160314143402 ProjectsAddPushesSinceGc: migrated (0.0251s) ================
    
    == 20160316123110 CiRunnersTokenIndex: migrating ==============================
    -- add_index(:ci_runners, :token, {:algorithm=>:concurrently})
       -> 0.0066s
    == 20160316123110 CiRunnersTokenIndex: migrated (0.0080s) =====================
    
    == 20160316124047 GitHooksProjectIdIndex: migrating ===========================
    -- add_index(:git_hooks, :project_id, {:algorithm=>:concurrently})
       -> 0.0092s
    == 20160316124047 GitHooksProjectIdIndex: migrated (0.0093s) ==================
    
    == 20160316192622 ChangeTargetIdToNullOnTodos: migrating ======================
    -- change_column_null(:todos, :target_id, true)
       -> 0.0007s
    == 20160316192622 ChangeTargetIdToNullOnTodos: migrated (0.0008s) =============
    
    == 20160316204731 AddCommitIdToTodos: migrating ===============================
    -- add_column(:todos, :commit_id, :string)
       -> 0.0016s
    -- add_index(:todos, :commit_id)
       -> 0.0062s
    == 20160316204731 AddCommitIdToTodos: migrated (0.0081s) ======================
    
    == 20160317092222 AddMovedToToIssue: migrating ================================
    -- add_reference(:issues, :moved_to, {:references=>:issues})
       -> 0.0008s
    == 20160317092222 AddMovedToToIssue: migrated (0.0009s) =======================
    
    == 20160317191509 AddLastSyncTimeToGroups: migrating ==========================
    -- add_column(:namespaces, :last_ldap_sync_at, :datetime)
       -> 0.0009s
    -- add_index(:namespaces, :last_ldap_sync_at)
       -> 0.0045s
    == 20160317191509 AddLastSyncTimeToGroups: migrated (0.0055s) =================
    
    == 20160320204112 IndexNamespacesOnVisibilityLevel: migrating =================
    -- index_exists?(:namespaces, :visibility_level)
       -> 0.0067s
    == 20160320204112 IndexNamespacesOnVisibilityLevel: migrated (0.0068s) ========
    
  • Sorry for the big walls of migrations, hoped these were collapsable

  • @zj Cool :thumbsup:

  • Reassigned to @DouweM

  • Douwe Maan Status changed to merged

    Status changed to merged

  • Douwe Maan mentioned in commit 89e82697

    mentioned in commit 89e82697

  • Picked into 8-6-stable-ee, will go into 8.6.1.

  • Rémy Coutable Removed ~149424 label

    Removed ~149424 label

  • Douwe Maan mentioned in commit f599a5b4

    mentioned in commit f599a5b4

  • mentioned in commit 025f79b6

  • Mentioned in commit 025f79b6

  • Douwe Maan Mentioned in commit 89e82697

    Mentioned in commit 89e82697

Please register or sign in to reply
Loading