Skip to content
Snippets Groups Projects

adds prometheus metrics to both mirro and remote mirror features

Merged Tiago Botelho requested to merge mirroring-prometheus-metrics into master
All threads resolved!

What does this MR do?

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Douwe Maan

Merge request reports

Pipeline #9128533 passed

Pipeline passed for c7b8b63e on mirroring-prometheus-metrics

Test coverage 46.86% from 2 jobs

Merged by avatar (Feb 23, 2025 6:59am UTC)

Merge details

  • Changes merged into with 8d470bff.
  • Deleted the source branch.

Pipeline #9138938 failed

Pipeline failed for 8d470bff on master

Test coverage 47.43% from 2 jobs
4 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Douwe Maan
  • Douwe Maan
  • Douwe Maan
  • Douwe Maan
  • Douwe Maan
  • Tiago Botelho added 1 commit

    added 1 commit

    • 20b62df8 - Adds prometheus metrics to both mirroring and remote mirroring features

    Compare with previous version

  • Tiago Botelho resolved all discussions

    resolved all discussions

  • @pchojnacki please post here when the fix is done so that I can remove the WIP :)

  • Tiago Botelho added 506 commits

    added 506 commits

    • 20b62df8...1501d7c9 - 505 commits from branch master
    • a9aa8308 - Adds prometheus metrics to both mirroring and remote mirroring features

    Compare with previous version

  • @tiagonbotelho https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12201 is merged but I just noticed this MR is for EE. Do you want me to backport it ?

  • @pchojnacki please do! and thank you for this <3

  • Tiago Botelho added 1 commit

    added 1 commit

    • 4350c9f1 - Adds prometheus metrics to both mirroring and remote mirroring features

    Compare with previous version

  • assigned to @DouweM

  • Douwe Maan
  • Douwe Maan
  • Tiago Botelho added 1 commit

    added 1 commit

    • a04bdc26 - Adds prometheus metrics to both mirroring and remote mirroring features

    Compare with previous version

  • Tiago Botelho added 1 commit

    added 1 commit

    • a04bdc26 - Adds prometheus metrics to both mirroring and remote mirroring features

    Compare with previous version

  • Tiago Botelho added 1 commit

    added 1 commit

    • c7b8b63e - Adds prometheus metrics to both mirroring and remote mirroring features

    Compare with previous version

  • assigned to @DouweM

  • Tiago Botelho added 1 commit

    added 1 commit

    • c7b8b63e - Adds prometheus metrics to both mirroring and remote mirroring features

    Compare with previous version

  • Tiago Botelho marked the checklist item Changelog entry added, if necessary as completed

    marked the checklist item Changelog entry added, if necessary as completed

  • Tiago Botelho marked the checklist item Documentation created/updated as completed

    marked the checklist item Documentation created/updated as completed

  • Tiago Botelho marked the checklist item API support added as completed

    marked the checklist item API support added as completed

  • Tiago Botelho marked the checklist item Added for this feature/bug as completed

    marked the checklist item Added for this feature/bug as completed

  • Tiago Botelho marked the checklist item All builds are passing as completed

    marked the checklist item All builds are passing as completed

  • Tiago Botelho marked the checklist item Conform by the merge request performance guides as completed

    marked the checklist item Conform by the merge request performance guides as completed

  • Tiago Botelho marked the checklist item Conform by the style guides as completed

    marked the checklist item Conform by the style guides as completed

  • Tiago Botelho marked the checklist item Branch has no merge conflicts with master (if it does - rebase it please) as completed

    marked the checklist item Branch has no merge conflicts with master (if it does - rebase it please) as completed

  • Tiago Botelho changed the description

    changed the description

  • Tiago Botelho marked the checklist item Squashed related commits together as completed

    marked the checklist item Squashed related commits together as completed

  • Douwe Maan resolved all discussions

    resolved all discussions

  • Douwe Maan unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Douwe Maan approved this merge request

    approved this merge request

  • Douwe Maan enabled an automatic merge when the pipeline for c7b8b63e succeeds

    enabled an automatic merge when the pipeline for c7b8b63e succeeds

  • merged

  • Douwe Maan mentioned in commit 8d470bff

    mentioned in commit 8d470bff

  • To help us understand mirror behaviour and to tweak our configuration to be able to handle the load better, we (me, @andrewn, supposedly @pcarranza) would like this MR live in production sooner rather than later. See https://gitlab.com/gitlab-com/infrastructure/issues/2138#note_33752117.

    Please sign off:

    Edited by Stan Hu
  • Douwe Maan changed milestone to %9.3

    changed milestone to %9.3

  • Douwe Maan mentioned in commit af4a5a2a

    mentioned in commit af4a5a2a

  • Picked into https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2300, will merge into 9.3-stable-ee ready for 9.3.3

  • mentioned in issue #2821 (closed)

  • Sean McGivern mentioned in commit 8daff950

    mentioned in commit 8daff950

  • Please register or sign in to reply
    Loading