Skip to content
Snippets Groups Projects

Resolve "Approvers don't appear when MR is created from a fork"

All threads resolved!

What does this MR do?

Use the target project, not the source project, for getting project members for the MR approvers dropdown.

Are there points in the code the reviewer needs to double check?

:shrug:

Why was this MR needed?

We accidentally broke this! When creating an MR from a fork, @project is the fork, not upstream.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests
    • Added for this feature/bug
    • All builds are passing

What are the relevant issue numbers?

Closes #2556 (closed).

Edited by Coung Ngo

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks for the quick fix @smcgivern! Greatly appreciated :purple_heart: ! I left just a one comment!

  • Sean McGivern added 1 commit

    added 1 commit

    • 835127cd - Fix approvers dropdown when creating MR from a fork

    Compare with previous version

  • Sean McGivern resolved all discussions

    resolved all discussions

  • Author Contributor

    @grzesiek thanks, fixed the spec!

  • assigned to @grzesiek

  • Grzegorz Bizon added 1 commit

    added 1 commit

    • aea415f9 - Fix typo in specs for merge request approvals

    Compare with previous version

  • Grzegorz Bizon resolved all discussions

    resolved all discussions

  • Grzegorz Bizon approved this merge request

    approved this merge request

  • Grzegorz Bizon enabled an automatic merge when the pipeline for aea415f9 succeeds

    enabled an automatic merge when the pipeline for aea415f9 succeeds

  • Thanks @smcgivern! MWPS set! Looks good to me! :thumbsup:

  • Grzegorz Bizon mentioned in commit 0bd4449d

    mentioned in commit 0bd4449d

  • Picked into 9-2-stable-ee; will go into v9.2.6-ee.

    /cc @selfup @ClemMakesApps @kushalpandya

  • Grzegorz Bizon mentioned in commit 9339dec6

    mentioned in commit 9339dec6

  • Coung Ngo changed the description

    changed the description

  • Please register or sign in to reply
    Loading