Resolve "Approvers don't appear when MR is created from a fork"
What does this MR do?
Use the target project, not the source project, for getting project members for the MR approvers dropdown.
Are there points in the code the reviewer needs to double check?
Why was this MR needed?
We accidentally broke this! When creating an MR from a fork, @project
is the fork, not upstream.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary - Tests
-
Added for this feature/bug -
All builds are passing
-
What are the relevant issue numbers?
Closes #2556 (closed).
Merge request reports
Activity
added 1 commit
- cb3ccde1 - Fix approvers dropdown when creating MR from a fork
changed milestone to %9.2
marked the checklist item Changelog entry added, if necessary as completed
@grzesiek could you take a look please?
assigned to @grzesiek
- Resolved by Sean McGivern
assigned to @smcgivern
Thanks for the quick fix @smcgivern! Greatly appreciated
! I left just a one comment!added 1 commit
- 835127cd - Fix approvers dropdown when creating MR from a fork
@grzesiek thanks, fixed the spec!
assigned to @grzesiek
- Resolved by Grzegorz Bizon
added 1 commit
- aea415f9 - Fix typo in specs for merge request approvals
enabled an automatic merge when the pipeline for aea415f9 succeeds
Thanks @smcgivern! MWPS set! Looks good to me!
mentioned in commit 0bd4449d
Picked into
9-2-stable-ee
; will go intov9.2.6-ee
.mentioned in commit 9339dec6
added devopsplan label
added Enterprise Edition label
removed Plan [DEPRECATED] label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@486a1a9a