Fix missing expose_path for license api paths
What does this MR do?
Part of closing https://gitlab.com/gitlab-org/gitlab-ee/issues/11121. Using api_v4_.*path
by itself does not include the relative_url_root, so it will cause 404 problems if not properly exposed.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Performance and testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Links
- Part of #11121 (closed)
Merge request reports
Activity
changed milestone to %11.11
added maintenancerefactor typebug labels
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Jarka Košanová ( @jarka
)Grzegorz Bizon ( @grzesiek
)Generated by
DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- d5c0159f - Fix missing expose_path for license api paths
removed maintenancerefactor label
added Category:License Compliance [DEPRECATED] label
@stanhu since you've been involved with this, do you mind reviewing and merging this small MR which adds some
expose_path
s?assigned to @stanhu
marked the checklist item Changelog entry as completed
marked the checklist item Documentation created/updated or follow-up review issue created as completed
marked the checklist item Code review guidelines as completed
marked the checklist item Merge request performance guidelines as completed
marked the checklist item Style guides as completed
marked the checklist item Database guides as completed
marked the checklist item Separation of EE specific content as completed
marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed
mentioned in issue #11121 (closed)
enabled an automatic merge when the pipeline for d5c0159f succeeds
mentioned in commit b2488d43
Automatically picked into https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/13779, will merge into
11-10-stable-ee
ready for11.10.6-ee
.mentioned in commit 9b4e54bb
mentioned in merge request !13779 (merged)
mentioned in issue gitlab-org/release/tasks#800 (closed)
added Enterprise Edition label