Namespace rename move_dir after_update bug

During a namespace rename, it is possible to stop callbacks after move_dir silently. With Geo, it is also possible to fail to create the event that moves the repository, wiki, and upload files on secondaries. Even though the namespace rename apparently succeeds on the primary.

How

• If send_update_instructions or write_projects_repository_config raise an exception in https://gitlab.com/gitlab-org/gitlab-ee/blob/v10.8.2-ee/app/models/concerns/storage/legacy_namespace.rb#L39
• Then we swallow the exception and return false

Consequence

• We don't produce any RepositoryRenamedEvents in https://gitlab.com/gitlab-org/gitlab-ee/blob/v10.8.2-ee/ee/app/models/ee/namespace.rb#L49
• We don't call refresh_access_of_projects_invited_groups in https://gitlab.com/gitlab-org/gitlab-ee/blob/v10.8.2-ee/app/models/namespace.rb#L52