Restrict individual approvers to project members or group members
To simplify assigning approvers, the search is now limited to project members for individual approvers
- Restrict the individual approvers in the approvers search box to be only project members or parent group members.
@victorwuis a member of the group that is the parent of this project, then
@victorwushould show up in the search box.
@victorwuis a member of a group that already has access to to this project via a share (i.e. #2048), then
@victorwushould show up in the search box. Note that this issue doesn't restrict the groups in the search box. That is handled in #2048.
@victorwuis member of the project (added to the project explicitly), then
@victorwucan show up in the search box.
- No other GitLab instance users can show up in the search box.
- This issue does not apply to groups that appear in the search box. Those are handled in #2048. That means if there is a group called
some-other-groupthat contains users not in the project or parent group, those groups may or may not show up in the search box. That restriction is handled in #2048.
- This applies to both the project settings and the per merge request settings.
When creating an MR the dropdown that you can use to search for approvers seems to include all users. This is not only bad for the UX (why would I want to have some random user review my MR?), but also for performance.