Global nav
- For gitlab-com&21 (closed)
- Closes https://gitlab.com/gitlab-com/gitlab-docs/issues/169
- Clean-up after https://gitlab.com/gitlab-com/gitlab-docs/merge_requests/356 - see all history there!
REVIEW APP: http://global-nav.178.62.207.141.xip.io/ce/README.html
MVC:
- Create the global nav
- Make it work on mobile (hidden on mobile ATM)
- BE review (just double check)
- FE review
FOR FE review:
- When we scroll down the nav, when it finishes scrolling, the page starts scrolling the content. Fix this to simply when the nav stops scrolling, just stop right there.
- Try to fix buggy ToC toggle (note that it's displayed only on mobile):
- the first click doesn't collapse it
- on the next clicks, there's a brief (weird) pause when the div is collapsing
PREVIEWING IT LOCALLY:
-
- Open a terminal in CE:
git pullgit checkout docs-add-global-nav
-
- Open a terminal in gitlab-docs:
git pullgit checkout global-navbundle install(to update the gems)bundle exec nanoc compilebundle exec nanoc live
-
- Preview at
http://localhost:3000/ce/README.html
- Preview at
BEFORE MERGING:
- Transfer
<%= render '/global_nav.*' %>to default doc and delete default-copy - Revert
.gitlab-ci.ymlto branchmaster
Edited by Marcia Ramos