Skip to content
GitLab Next
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Menu
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • GitLab Docs GitLab Docs
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 164
    • Issues 164
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab DocsGitLab Docs
  • Merge requests
  • !472

Add support for embedded videos

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Marcia Ramos requested to merge embed-videos into master Jun 18, 2019
  • Overview 15
  • Commits 4
  • Pipelines 4
  • Changes 1
  • This MR introduces support for embedded videos with a fallback for /help. Thumbnails and special styling can come later.
  • Follow-up from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29683.
  • Implementation per Mike's requested on Slack:

@mikelewis:

@marcia I think we should have the capability to easily embed videos like that, and also create some kind of expanding video link that uses a video icon or thumbnail.

Review App: http://embed-videos.178.62.207.141.xip.io/ce/development/documentation/styleguide.html#embedded-videos

Todos:

  • Roll back .gitlab-ci.yml changes for review app
  • Merge this MR
  • Merge https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29683

Also: discuss with the team the guidelines for embedding videos and document them.

Edited Jun 27, 2019 by Marcia Ramos
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: embed-videos