Skip to content

Remove Vue 3 testing and clean up peer dependencies

Sarah German requested to merge yarn-fix-peer-deps-warnings into main

What does this MR do and why?

This MR aims to simplify frontend dependencies in the gitlab-docs project, where we are slowing down development in order to move gitlab-docs-hugo forward. Since we now need to do updates manually (gitlab-org/frontend/renovate-gitlab-bot!776 (merged)), dropping some unnecessary development dependencies will lessen the amount of updates we need to review and apply.

  • Drops Vue 3 tests. The Vue 3 upgrade will not happen in this project, and the tests require several dependencies. We will reintroduce these in the Hugo project (unless we can go straight to Vue 3 by then).
  • Fixes peer dependency warnings on install. These were innocuous but confusing to TWs running local sites (Slack).
  • Silences the CJS warning ("The CJS build of Vite's Node API is deprecated") from Rollup/Vite. This warning is also innocuous but has also been confusing to people (Slack). We have removed the deprecated build tool in gitlab-docs-hugo.

Screenshots, screen recordings, or links to review app

before after
image image
image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Configure a local GitLab Docs environment: https://gitlab.com/gitlab-org/gitlab-docs/-/blob/main/doc/setup.md.
  2. Run make setup
  3. Yarn should no longer print peer dependency warnings; rollup should no longer print deprecation notices

Merge request acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sarah German

Merge request reports