Adjust encoding for search queries with spaces
What does this MR do and why?
Closes #1636 (closed)
We need to encode spaces in search queries with a +
rather than a *
in order for exact match searches (using "
characters) to work as expected (see "Default Search" here).
Separating words with the asterisk was running a wildcard search, which worked fine when not looking for exact matches, but this was not compatible with the exact match syntax.
Screenshots, screen recordings, or links to review app
Before | After |
---|---|
How to validate
Numbered steps to set up and validate the change are strongly suggested.
-
Visit the review app -
Run a search in quotes, like "style guide"
or"auto devops"
-
You should see results for these searches (and on the production site, you do not).
Keep in mind that sometimes Google will modify queries on their end, so not all searches in quotes were affected by this (e.g, a search for "gitlab runner" on the production site does not have this issue).
Merge request acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this merge request.
Closes #1636 (closed)