Skip to content

Execute review job earlier

Lukas Eipert requested to merge leipert-execute-review-earlier into main

What does this MR do and why?

Execute review job earlier

It seems like the only dependency of the review job are compile_dev or compile_upstream_review_app depending on pipeline type.

If we declare that explicitly, we can execute the job right away, allowing the pipeline to finish earlier.

Furthermore we can have a shared set of rules for review and review_stop.

Screenshots, screen recordings, or links to review app

N/A

How to set up and validate locally

It's CI, how would you do that 😆

  1. Configure a local GitLab Docs environment: https://gitlab.com/gitlab-org/gitlab-docs/-/blob/main/doc/setup.md.

Merge request acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lukas Eipert

Merge request reports