Skip to content

Fix Lint/UnusedBlockArgument RuboCop violations from frontend.rb

Evan Read requested to merge eread/clear-rubocop-violations-from-frontend_rb into main

What does this MR do and why?

Fix Lint/UnusedBlockArgument RuboCop violations from frontend.rb.

Cri library seems to need certain arguments (https://github.com/denisdefreyne/cri#usage) to be passed to its functions, but we don't use them all. This MR adds "known unused" marker to them: https://docs.rubocop.org/rubocop/cops_lint.html#lintunusedblockargument.

We may not need to technically keep all these arguments to get the function to work (for example, if you remove all the arguments from run, you get ArgumentError: The block given to Cri::Command#run expects two or three args), but I thought I'd keep it mostly as it was.

While here, I added some color coding to the output to match what we do elsewhere.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Configure a local GitLab Docs environment: https://gitlab.com/gitlab-org/gitlab-docs/-/blob/main/doc/setup.md.
  2. Run bundle exec nanoc frontend.

Merge request acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Evan Read

Merge request reports