Skip to content

Draft: Update plugin-node-resolve dependency

Evan Read requested to merge eread/update-plugin_node_resolve-dependency into main

What does this MR do and why?

I was curious as to whether we could update one of the Node.js dependencies we don't update: https://gitlab.com/gitlab-org/frontend/renovate-gitlab-bot/-/blob/df7db2610c7fe9b22c605932e78e5359eb218220/renovate/gitlab-docs/gitlab-docs.config.js#L23.

Updating just plugin-node-resolve results in build warnings. I think the warnings are coming from preferBuiltins: false. In the documentation for plugin-node-resolve (https://github.com/rollup/plugins/tree/master/packages/node-resolve/#resolving-built-ins-like-fs), it mentions using an additional plugin.

The docs mention https://github.com/ionic-team/rollup-plugin-node-polyfills, but the build warnings mention https://github.com/FredKSchott/rollup-plugin-polyfill-node. I selected the second one which looks like the right choice.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Configure a local GitLab Docs environment: https://gitlab.com/gitlab-org/gitlab-docs/-/blob/main/doc/setup.md.

Merge request acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports