Skip to content

Set the APPS_DOMAIN variable in .gitlab-ci.yml

Achilleas Pipinellis requested to merge axil-app-domain-ci-yaml into main

We currently define the APPS_DOMAIN variable in the CI/CD settings, but there's no reason to do this:

  • The review apps domain name is public.
  • Setting it in .gitlab-ci.yml make this more transparent and easier to debug.
  • All the other products we pull from have this set in .gitlab-ci.yml as well.

This will also help us distinguish from the old 35.193.151.162.nip.io domain name, which is still used for branches older than 15.5 (#1315 (closed)).

After this change, we can delete the APPS_DOMAIN variable in the CI/CD settings.

Edited by Achilleas Pipinellis

Merge request reports