Skip to content

WIP: POC: Don't collapse version notes for disabled features

Marcel Amirault requested to merge version-notes-for-disabled-features into master

Users are having a hard time noticing that some features are disabled by default and not accessible. This simple change causes the version notes to be uncollapsed if the word "disabled" is found in the notes, which should make it much clearer that the feature is not available in some cases. If the words are changed to "enabled", it collapses again. This means both lines like below need to change before it collapses, to avoid confusion:

  • It's deployed behind a feature flag, disabled by default.
  • It's disabled on GitLab.com.

I also removed the GitLab from the regex that detects version notes, as it seemed superfluous (and in fact, was causing one of the version notes to not be collapsed in the example).

A good example to check in the review app is: http://version-notes-for-disabled-features.178.62.207.141.nip.io/ee/user/project/issues/design_management.html

In the screenshots below, I manually uncollapsed the first example, to show the word "disabled" is not present, but you can see the ellipsis is present there, but not present in the last two examples that are not collapsed:

Before After Contains disabled?
Screen_Shot_2020-07-15_at_13.49.31 Screen_Shot_2020-07-15_at_13.50.05 No
Screen_Shot_2020-07-15_at_13.51.23 Screen_Shot_2020-07-15_at_13.51.03 No
Screen_Shot_2020-07-15_at_13.53.53 Screen_Shot_2020-07-15_at_13.54.01 Yes
Screen_Shot_2020-07-15_at_15.18.58 Screen_Shot_2020-07-15_at_13.55.19 Yes
Edited by Marcel Amirault

Merge request reports